Use constant instead of literal string for wbMobile parser option

We use the literal string `wbMobile` in many places in the Wikibase
codebase to refer to the parser option for mobile (and now wbui2025)
functionality.

Replace the literal string with a constant.

Bug: T407737
Change-Id: Ib3ec93c27e515c8f4a68822ef4f5cb206a6a6964

Author: codders

repo/includes/ParserOutput/EntityParserOutputGeneratorFactory.php

@@ -26,6 +26,7 @@
 use Wikibase\Repo\Hooks\WikibaseRepoOnParserOutputUpdaterConstructionHook;
 use Wikibase\Repo\LinkedData\EntityDataFormatProvider;
 use Wikibase\Repo\WikibaseRepo;
+use Wikibase\View\Wbui2025FeatureFlag;
 use Wikimedia\Stats\StatsFactory;
 
 /**
@@ -146,7 +147,7 @@ public function getEntityParserOutputGeneratorForParserOptions( ParserOptions $o
 			$this->entityDataFormatProvider,
 			$this->getDataUpdaters(),
 			$userLanguage,
-			$options->getOption( 'wbMobile' ),
+			$options->getOption( Wbui2025FeatureFlag::PARSER_OPTION_NAME ),
 			$this->isMobileView
 		);
 

repo/includes/ParserOutput/FullEntityParserOutputGenerator.php

@@ -166,7 +166,7 @@ private function addHtmlToParserOutput(
 		$parserOutput->setTitleText( $titleHtml ?? '' );
 
 		// split parser cache by desktop/mobile/wbui2025 (T344362, T394291, T394291)
-		$parserOutput->recordOption( 'wbMobile' );
+		$parserOutput->recordOption( Wbui2025FeatureFlag::PARSER_OPTION_NAME );
 		$viewContent = $entityView->getContent( $entity, $entityRevision->getRevisionId() );
 		$parserOutput->setContentHolderText( $viewContent->getHtml() );
 
@@ -187,7 +187,7 @@ private function addModules( ParserOutput $parserOutput ): void {
 			'wikibase.alltargets',
 		] );
 		// split parser cache by desktop/mobile (T344362)
-		$parserOutput->recordOption( 'wbMobile' );
+		$parserOutput->recordOption( Wbui2025FeatureFlag::PARSER_OPTION_NAME );
 		// T324991
 		if ( !$this->isMobileView ) {
 			$parserOutput->addModuleStyles( [

repo/includes/RepoHooks.php

@@ -72,6 +72,7 @@
 use Wikibase\Repo\Store\Sql\SqlSubscriptionLookup;
 use Wikibase\View\ViewHooks;
 use Wikibase\View\VueNoScriptRendering;
+use Wikibase\View\Wbui2025FeatureFlag;
 use Wikimedia\Rdbms\IDBAccessObject;
 
 /**
@@ -1145,9 +1146,9 @@ public function onParserOptionsRegister( &$defaults, &$inCacheKey, &$lazyLoad )
 				TermboxView::TERMBOX_VERSION . TermboxView::CACHE_VERSION :
 				PlaceholderEmittingEntityTermsView::TERMBOX_VERSION . PlaceholderEmittingEntityTermsView::CACHE_VERSION;
 		};
-		$defaults['wbMobile'] = null;
-		$inCacheKey['wbMobile'] = true;
-		$lazyLoad['wbMobile'] = function ( ParserOptions $parserOptions ) {
+		$defaults[Wbui2025FeatureFlag::PARSER_OPTION_NAME] = null;
+		$inCacheKey[Wbui2025FeatureFlag::PARSER_OPTION_NAME] = true;
+		$lazyLoad[Wbui2025FeatureFlag::PARSER_OPTION_NAME] = function ( ParserOptions $parserOptions ) {
 			return WikibaseRepo::getWbui2025FeatureFlag()->generateWbMobileFlagValue(
 				WikibaseRepo::getMobileSite(),
 				$parserOptions->getUserIdentity(),

repo/tests/phpunit/includes/Content/ItemHandlerTest.php

@@ -27,6 +27,7 @@
 use Wikibase\Repo\Content\ItemHandler;
 use Wikibase\Repo\Search\Fields\FieldDefinitions;
 use Wikibase\Repo\WikibaseRepo;
+use Wikibase\View\Wbui2025FeatureFlag;
 
 /**
  * @covers \Wikibase\Repo\Content\ItemHandler
@@ -320,7 +321,7 @@ public function testGetParserOutput() {
 		$title = Title::makeTitle( NS_MAIN, 'Foo' );
 		$parserOutput = $contentRenderer->getParserOutput( $content, $title );
 
-		$expectedUsedOptions = [ 'userlang', 'wb', 'termboxVersion', 'wbMobile' ];
+		$expectedUsedOptions = [ 'userlang', 'wb', 'termboxVersion', Wbui2025FeatureFlag::PARSER_OPTION_NAME ];
 		$actualOptions = $parserOutput->getUsedOptions();
 		$this->assertEqualsCanonicalizing(
 			$expectedUsedOptions,

repo/tests/phpunit/includes/Content/PropertyHandlerTest.php

@@ -17,6 +17,7 @@
 use Wikibase\Repo\Content\PropertyContent;
 use Wikibase\Repo\Content\PropertyHandler;
 use Wikibase\Repo\WikibaseRepo;
+use Wikibase\View\Wbui2025FeatureFlag;
 
 /**
  * @covers \Wikibase\Repo\Content\PropertyHandler
@@ -202,7 +203,7 @@ public function testGetParserOutput() {
 		$title->setContentModel( CONTENT_MODEL_WIKITEXT );
 		$parserOutput = $contentRenderer->getParserOutput( $content, $title );
 
-		$expectedUsedOptions = [ 'userlang', 'wb', 'termboxVersion', 'wbMobile' ];
+		$expectedUsedOptions = [ 'userlang', 'wb', 'termboxVersion', Wbui2025FeatureFlag::PARSER_OPTION_NAME ];
 		$actualOptions = $parserOutput->getUsedOptions();
 		$this->assertEqualsCanonicalizing(
 			$expectedUsedOptions,

repo/tests/phpunit/includes/RepoHooksTest.php

@@ -31,6 +31,7 @@
 use Wikibase\Repo\RepoHooks;
 use Wikibase\Repo\Store\RateLimitingIdGenerator;
 use Wikibase\Repo\WikibaseRepo;
+use Wikibase\View\Wbui2025FeatureFlag;
 use WikiImporter;
 
 /**
@@ -395,26 +396,26 @@ public function testOnParserOptionsRegister(
 		$this->assertSame( [
 			'wb' => null,
 			'termboxVersion' => null,
-			'wbMobile' => null,
+			Wbui2025FeatureFlag::PARSER_OPTION_NAME => null,
 		], $defaults );
 		$this->assertSame( [
 			'wb' => true,
 			'termboxVersion' => true,
-			'wbMobile' => true,
+			Wbui2025FeatureFlag::PARSER_OPTION_NAME => true,
 		], $inCacheKey );
 		$this->assertSame( [
 			'wb',
 			'termboxVersion',
-			'wbMobile',
+			Wbui2025FeatureFlag::PARSER_OPTION_NAME,
 		], array_keys( $lazyOptions ) );
 		$parserOptions = $this->createConfiguredMock( ParserOptions::class, [
 			'getUserIdentity' => $this->createMock( UserIdentity::class ),
 		] );
 		$this->assertIsCallable( $lazyOptions[ 'wb' ] );
 		$this->assertSame( EntityHandler::PARSER_VERSION, $lazyOptions[ 'wb' ]() );
 		$this->assertIsCallable( $lazyOptions[ 'termboxVersion' ] );
-		$this->assertIsCallable( $lazyOptions[ 'wbMobile' ] );
-		$this->assertSame( $expectedWbMobileValue, $lazyOptions[ 'wbMobile' ]( $parserOptions ) );
+		$this->assertIsCallable( $lazyOptions[ Wbui2025FeatureFlag::PARSER_OPTION_NAME ] );
+		$this->assertSame( $expectedWbMobileValue, $lazyOptions[ Wbui2025FeatureFlag::PARSER_OPTION_NAME ]( $parserOptions ) );
 	}
 
 	public function testOnParserOptionsRegister_hook() {

view/src/Wbui2025FeatureFlag.php

@@ -17,6 +17,7 @@ class Wbui2025FeatureFlag {
 	public const OPTION_NAME = 'wikibase-mobile-editing-ui';
 	public const EXTENSION_DATA_KEY = 'wikibase-mobile';
 	public const WBMOBILE_WBUI2025_FLAG = 'wbui2025';
+	public const PARSER_OPTION_NAME = 'wbMobile';
 
 	private UserOptionsLookup $userOptionsLookup;
 	private bool $wbui2025Enabled;