WFCORE-6995 Allow stability-specific resource transformations for mixed domains #6214

pferraro · 2024-10-11T13:15:29Z

https://issues.redhat.com/browse/WFCORE-6995

~~Submitting as a draft while I collect feedback and add tests.~~

@yersan Until https://github.com/wildfly/wildfly-legacy-test publishes releases for WildFly versions, it will be impossible to create model transformation tests for COMMUNITY stability.

wildfly-ci · 2024-10-17T22:23:26Z

Core -> WildFly Preview Integration Build 14066 outcome was FAILURE using a merge of e05436b
Summary: Tests passed: 5009, ignored: 58; exit code 1 (Step: Build & test full (Maven)) Build time: 02:48:20

wildfly-ci · 2024-10-18T14:40:11Z

Core -> WildFly Preview Integration Build 14067 outcome was FAILURE using a merge of e05436b
Summary: Exit code 1 (Step: Build & test full (Maven)) Build time: 00:05:30

github-actions · 2024-12-15T01:04:09Z

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

wildfly-ci · 2024-12-16T12:21:19Z

Core -> Full Integration Build 14427 outcome was UNKNOWN using a merge of c997c15
Summary: Canceled (Error while applying patch; cannot find commit c7edee2 in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/6214/merge branch was updated and the commit selected for the ... Build time: 00:00:34

wildfly-ci · 2024-12-16T12:21:34Z

Core -> Full Integration Build 14126 outcome was UNKNOWN using a merge of c997c15
Summary: Canceled (Error while applying patch; cannot find commit c7edee2 in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/6214/merge branch was updated and the commit selected for the ... Build time: 00:00:15

wildfly-ci · 2024-12-16T12:22:03Z

Core -> WildFly Preview Integration Build 14208 outcome was UNKNOWN using a merge of c997c15
Summary: Canceled (Error while applying patch; cannot find commit c7edee2 in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/6214/merge branch was updated and the commit selected for the ... Build time: 00:00:15

github-actions · 2025-02-01T00:56:17Z

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

…ed domains

…s using SubsystemModel enumerations.

yersan

Just added comments, I do not have the expertise on transformers API to validate the work done here, it should be fine since the BasicResourceTestCase explicitly tests all of those transformations, but I got the impression there is still pending work to do to enable the server to use the expected stability level when it is registering the transformers, that;s still a bit unclear to me

yersan · 2025-02-14T12:19:20Z

...r/src/main/java/org/jboss/as/controller/transform/SubsystemModelTransformerRegistration.java

+        for (E model : EnumSet.complementOf(EnumSet.of(this.currentSubsystemModel))) {
+            ModelVersion version = model.getVersion();
+            ResourceTransformationDescriptionBuilder builder = registration.createResourceTransformationDescriptionBuilder();
+            this.transformation.accept(builder, version);
+            TransformationDescription.Tools.register(builder.build(), registration, version);
+        }


Do we have an example of how to use this class?

I'm not a SME in these transformers and it is too big to digest it easily, but I guess what I cannot see is how this new way to register the transformers will be able to match what we currently have. At this moment, transformers are registered as a chain, with a common builder that registers the transformation from one version to another, however here we are only registering a single version with a specific builder, so I get lost on this.

yersan · 2025-02-14T12:31:15Z

controller/src/main/java/org/jboss/as/controller/transform/TransformerRegistry.java

+        @Deprecated(forRemoval = true)
        public static TransformerRegistry create() {
-            return new TransformerRegistry();
+            return create(Stability.DEFAULT);
        }


What happens with the current usage of this method in our code? Shouldn't we at least force the creation of a transformer registry using a specific Stability level? Otherwise, we will continue using the wrong registry and we won't be able yet to add specific transformations to the subsystems.

yersan · 2025-02-14T12:45:36Z

...controller/src/main/java/org/jboss/as/domain/controller/transformers/DomainTransformers.java

+        ChainedTransformationDescriptionBuilderFactory factory = KernelAPIVersion.createChainedTransformationDescriptionBuilderFactory(registry);
+        registerChainedManagementTransformers(registry, factory);
+        registerChainedServerGroupTransformers(registry, factory);
        registerProfileTransformers(registry);
-        registerSocketBindingGroupTransformers(registry);
-        registerDeploymentTransformers(registry);
+        registerSocketBindingGroupTransformers(registry, factory);
+        registerDeploymentTransformers(registry, factory);


Why we are only changing the Domain Transformers? Shouldn't we also change and adapt in this PR how we are registering the other transformers?

For example, at ElytronSubsystemTransformers we have:

@Override public void registerTransformers(SubsystemTransformerRegistration registration) { ChainedTransformationDescriptionBuilder chainedBuilder = TransformationDescriptionBuilder.Factory.createChainedSubystemInstance(registration.getCurrentSubsystemVersion());

What would be the equivalent code to create ChainedTransformationDescriptionBuilder using the current Stability level?

github-actions · 2025-04-01T01:05:36Z

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

pferraro · 2025-04-02T17:35:58Z

Bump (to prevent github autoclose)

github-actions · 2025-05-18T01:06:44Z

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

pferraro · 2025-05-22T08:57:24Z

Bump (to prevent github autoclose). @bstansberry Are we still interested in this? If so, can you take a look?

bstansberry

@pferraro I had a look and made comments. I think Yeray's earlier are the more critical ones.

Re whether we are interested in this, TBH I'm relying on you and @yersan to tell me. I think we are because in all the discussions about it we keep working on it and I think we'd stop if we decided not to do it. ;) But the details of the back-and-forth are flushed from memory, partly because I'm relying on you guys.

bstansberry · 2025-05-22T16:32:36Z

...jboss/as/controller/transform/description/AttributeTransformationDescriptionBuilderImpl.java

-        for (String attribute : rejectedAttributes) {
-            registry.addAttributeCheck(attribute, rejectChecker);
+        for (String rejectedAttribute : rejectedAttributes) {
+            this.registry.addAttributeCheck(rejectedAttribute, rejectChecker);
        }


Should this method be deprecated? Just reading the diff it seems like it's unable to apply the desired 'enables' check so it's just assuming. Which is ok temporarily but perhaps should be deprecated.

It seems like the javadoc in the interface should explain the behavior re the 'enables' call for all the methods.

bstansberry · 2025-05-22T16:32:59Z

...jboss/as/controller/transform/description/AttributeTransformationDescriptionBuilderImpl.java

        }
        return thisBuilder();
    }

    @Override
    public T addRejectChecks(List<RejectAttributeChecker> rejectCheckers, String... rejectedAttributes) {
        for (RejectAttributeChecker rejectChecker : rejectCheckers) {
-            addRejectCheck(rejectChecker, rejectedAttributes);
+            this.addRejectCheck(rejectChecker, rejectedAttributes);


Same comment re deprecation.

bstansberry · 2025-05-22T16:33:20Z

...jboss/as/controller/transform/description/AttributeTransformationDescriptionBuilderImpl.java

    public T addRenames(Map<String, String> renames) {
        for (Map.Entry<String, String> rename : renames.entrySet()) {
-            registry.addRenamedAttribute(rename.getKey(), rename.getValue());
+            this.addRename(rename.getKey(), rename.getValue());


Same comment re deprecation.

bstansberry · 2025-05-22T16:33:41Z

...jboss/as/controller/transform/description/AttributeTransformationDescriptionBuilderImpl.java

@@ -131,10 +132,6 @@ public T setValueConverter(AttributeConverter attributeConverter, String... conv
        return thisBuilder();


Same comment re deprecation.

bstansberry · 2025-05-22T16:37:37Z

.../org/jboss/as/controller/transform/description/ResourceTransformationDescriptionBuilder.java

     */
-    ResourceTransformationDescriptionBuilder addChildResource(ResourceDefinition definition);
+    @Deprecated(forRemoval = true)


Note to reviewers: I only see 5 uses of this in WF, all in the legacy Picketbox extensions.

bstansberry · 2025-05-22T16:38:15Z

.../org/jboss/as/controller/transform/description/ResourceTransformationDescriptionBuilder.java

     */
-    ResourceTransformationDescriptionBuilder addChildResource(ResourceDefinition definition, DynamicDiscardPolicy dynamicDiscardPolicy);
-
+    @Deprecated(forRemoval = true)


Note to reviewers: I don't see any uses of this in WF.

bstansberry · 2025-05-22T16:40:12Z

.../org/jboss/as/controller/transform/description/ResourceTransformationDescriptionBuilder.java

     */
+    @Deprecated(forRemoval = true)


Note to reviewers: I see no use in WF.

yersan · 2025-05-28T11:44:54Z

@pferraro I had a look and made comments. I think Yeray's earlier are the more critical ones.

Re whether we are interested in this, TBH I'm relying on you and @yersan to tell me. I think we are because in all the discussions about it we keep working on it and I think we'd stop if we decided not to do it. ;) But the details of the back-and-forth are flushed from memory, partly because I'm relying on you guys.

This is something good to have, since it will allow us to test community-community paired stability levels in mixed domains. I don't see it as something urgent to do; I have never read issues with mixed domains on the community side, so, probably something that is not widely used. It brings up more maintenance, and the fix indeed looks complex. However, having those tests in practice is good and necessary. It will also help later to future promotions by moving a feature from community stability to a higher one.

@pferraro I don't know how complex this would end up at the end, not only on the solution but also on the future maintenance, so if you still have doubts whether this is necessary, I would be fine because I don't think this scenario is widely used in upstream.

pferraro force-pushed the WFCORE-6995 branch from 406466c to 8653a65 Compare October 11, 2024 14:41

pferraro requested a review from yersan October 16, 2024 09:14

pferraro force-pushed the WFCORE-6995 branch 3 times, most recently from 7be71fb to e05436b Compare October 17, 2024 19:31

This comment was marked as off-topic.

Sign in to view

pferraro marked this pull request as ready for review October 18, 2024 14:35

This comment was marked as off-topic.

Sign in to view

yersan mentioned this pull request Nov 27, 2024

[WFCORE-7011] Use 'default' stability level when the remote host controller do not advertise its current stability level #6204

Merged

github-actions bot added the Stale label Dec 15, 2024

pferraro force-pushed the WFCORE-6995 branch from e05436b to c997c15 Compare December 16, 2024 10:10

github-actions bot removed the Stale label Dec 17, 2024

github-actions bot added the Stale label Feb 1, 2025

pferraro added 3 commits February 10, 2025 18:09

WFCORE-6995 Allow stability-specific resource transformations for mix…

ad7f88f

…ed domains

Generic ExtensionTransformerRegistration implementation for subsystem…

1222d02

…s using SubsystemModel enumerations.

Remove superfluous rejection of non-existent resource.

aa426d5

pferraro force-pushed the WFCORE-6995 branch from c997c15 to aa426d5 Compare February 10, 2025 18:28

github-actions bot removed the Stale label Feb 11, 2025

yersan reviewed Feb 14, 2025

View reviewed changes

github-actions bot added the Stale label Apr 1, 2025

github-actions bot removed the Stale label Apr 3, 2025

github-actions bot added the Stale label May 18, 2025

bstansberry reviewed May 22, 2025

View reviewed changes

github-actions bot removed the Stale label May 23, 2025

		@@ -131,10 +132,6 @@ public T setValueConverter(AttributeConverter attributeConverter, String... conv
		return thisBuilder();

WFCORE-6995 Allow stability-specific resource transformations for mixed domains #6214

Are you sure you want to change the base?

WFCORE-6995 Allow stability-specific resource transformations for mixed domains #6214

Uh oh!

Conversation

pferraro commented Oct 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as off-topic.

wildfly-ci commented Oct 17, 2024

Uh oh!

wildfly-ci commented Oct 18, 2024

Uh oh!

This comment was marked as off-topic.

github-actions bot commented Dec 15, 2024

Uh oh!

wildfly-ci commented Dec 16, 2024

Uh oh!

wildfly-ci commented Dec 16, 2024

Uh oh!

wildfly-ci commented Dec 16, 2024

Uh oh!

github-actions bot commented Feb 1, 2025

Uh oh!

yersan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 1, 2025

Uh oh!

pferraro commented Apr 2, 2025

Uh oh!

github-actions bot commented May 18, 2025

Uh oh!

pferraro commented May 22, 2025

Uh oh!

bstansberry left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yersan commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

pferraro commented Oct 11, 2024 •

edited

Loading

yersan commented May 28, 2025 •

edited

Loading