Skip to content

Conversation

@hollowsunhc
Copy link

  • Updated fmt to version 11.2.0

  • spdlog had to be updated to match the updated fmt. spdlog was updated to version 1.15.2

  • Replaced the removed function std::random_shuffle by std::shuffle and providing a mersenne twister as the pseudo-number generator.

The mersenne twister has better statistical properties than the internal std::rand used in std::random_shuffle but perhaps, it may have unintended negative consequences. I'm not exactly sure about the impact of such a change.

@hollowsunhc
Copy link
Author

If reproducibility is a requirement, perhaps it is better to replace std::random_device by std::mt19937.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant