Yash.claw #4
Open
Yash.claw #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruzyna
requested changes
Feb 16, 2023
src/main/java/org/wildstang/year2023/subsystems/ArmEverybot.java
Outdated
Show resolved
Hide resolved
Comment on lines
+45
to
+50
| mSpeed2 = 0.8; | ||
| } | ||
| if (sourceInput == dPadButton2){ | ||
| if (dPadButton2.getValue()){ | ||
| mSpeed2 = 0.8; | ||
| } |
src/main/java/org/wildstang/year2023/subsystems/ArmEverybot.java
Outdated
Show resolved
Hide resolved
src/main/java/org/wildstang/year2023/subsystems/TankDriveEverybot.java
Outdated
Show resolved
Hide resolved
src/main/java/org/wildstang/year2023/subsystems/TankDriveEverybot.java
Outdated
Show resolved
Hide resolved
Post Liam critiques
fruzyna
requested changes
Feb 16, 2023
| public void inputUpdate(Input sourceInput) { | ||
| // TODO Auto-generated method stub | ||
| if (sourceInput == forwardTrigger || sourceInput == backTrigger){ | ||
| if (sourceInput == forwardTrigger){ |
There was a problem hiding this comment.
Get rid of this second level of if statements and merge the 2 3rd levels
| @Override | ||
| public void inputUpdate(Input sourceInput) { | ||
| if (sourceInput == lefttrigger || sourceInput == righttrigger){ | ||
| if (sourceInput == lefttrigger) { |
There was a problem hiding this comment.
Get rid of this second level of if statements and merge the 2 3rd levels
| else { | ||
| motor.setCoast(); | ||
| } | ||
| if (motorSpeed == 0){ |
There was a problem hiding this comment.
You probably want 2 different speeds for left and right
| public void update() { | ||
| // TODO Auto-generated method stub | ||
| motor.setValue(motorSpeed); | ||
| if (motorSpeed == motor.getValue() || motorSpeed == motor2.getValue()){ |
There was a problem hiding this comment.
What is this trying to accomplish?
| @@ -41,6 +41,8 @@ public enum WSOutputs implements Outputs { | |||
| ANGLE3("Module 3 Angle Motor", new WsSparkMaxConfig(CANConstants.ANGLE3, true)), | |||
| DRIVE4("Module 4 Drive Motor", new WsSparkMaxConfig(CANConstants.DRIVE4, true)), | |||
| ANGLE4("Module 4 Angle Motor", new WsSparkMaxConfig(CANConstants.ANGLE4, true)), | |||
| EVERYBOT1("Module 4 Angle Motor", new WsSparkMaxConfig(CANConstants.EVERYBOT1, true)), | |||
| EBOT2("Module 4 Angle Motor", new WsSparkMaxConfig(CANConstants.EBOT2, true)), | |||
There was a problem hiding this comment.
Assuming you missed adding this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
Please fill out the fields below by replacing their explaination text.
Subsystem: Affected Subsystem name
Everybot
Description:
Describe your changes in a few sentences.
coded the tank drive and arm of the Everybot. Tank drive uses a simple motor and if statement commands. Arm is a tad longer using a boolean for the dpad options but it has 2 motors as well as a good amount of if statements.
Tested: Yes/No was your code tested on a robot or simulator?
Checked on VS Code Build function, both folders were successful
Checking that the code has built locally is important, but that is not testing.
If yes, please elaborate.
Collaborators: List anyone else who worked on this PR, preferably with @s
@fruzyna walked me through the process of coding the everybot.
Before submitting: