Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to axum 0.8 #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

adalpane662
Copy link

Objective

This is the minimal changeset required to use datadog-tracing with axum version 0.8 and above.

Proposed changes

  • Increase project version from 0.2.3 to 0.3.0 to signal the breaking change
  • Remove all direct dependency on axum version 0.7 and also upgrade axum-tracing-opentelemetry to the minimal version referring to axum version 0.8
  • Depend on major versions of stable crates

@willbank-platforms
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

1 similar comment
@willbank-platforms
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@willbank-platforms
Copy link

Error parsing command: EOF found when expecting closing quote

3 similar comments
@willbank-platforms
Copy link

Error parsing command: EOF found when expecting closing quote

@willbank-platforms
Copy link

Error parsing command: EOF found when expecting closing quote

@willbank-platforms
Copy link

Error parsing command: EOF found when expecting closing quote

@digitalillusion
Copy link

@fhsgoncalves Hi, can you check the automation here ?

Copy link
Member

@fhsgoncalves fhsgoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Tks for the contribution! 🎉
We are gonna take a look at the atlantis automation, but you can ignore it for now :)

I'm gonna test this change and after that, publish the new version

@fhsgoncalves
Copy link
Member

Can you update the example with axum 0.8, and make sure it's running properly?

@willbank-platforms
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

1 similar comment
@willbank-platforms
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@willbank-platforms
Copy link

Error parsing command: EOF found when expecting closing quote

3 similar comments
@willbank-platforms
Copy link

Error parsing command: EOF found when expecting closing quote

@willbank-platforms
Copy link

Error parsing command: EOF found when expecting closing quote

@willbank-platforms
Copy link

Error parsing command: EOF found when expecting closing quote

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants