Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix implements
RetryTransport.close()and.aclose()so the inner transports are freed whenhttpx.Client.close()orhttpx.Client.aclose()is called. This avoids resource warnings about leaked SSL sockets when Python exits, e.g.:Decisions:
RetryTransport.__init__, so I implemented the same behavior ashttpx.Client.close(), which is to close all transports irrespective of where they came from.RetryTransport.__init__creates both sync and async transports if you don't pass one in, butRetryTransport.close()and.aclose()only close their own transport. I don't think this would cause problems since the one you close is likely the one you use, so the transport you don't close probably didn't ever open any sockets.