-
-
Notifications
You must be signed in to change notification settings - Fork 137
feat: Add freeplane #1452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add freeplane #1452
Conversation
01-main/packages/freeplane
Outdated
# Find the latest .deb URL for the current naming pattern | ||
local REDIR_URL="$(grep -Eo 'https://downloads\.sourceforge\.net/project/freeplane/[^"\ >]+' "${CACHE_FILE}" | grep 'freeplane_[0-9.]*~upstream-[0-9]+_all.deb' | head -n1)" | ||
URL=$(unroll_url "${REDIR_URL}") | ||
VERSION_PUBLISHED="$(echo "${URL}" | grep -oP 'freeplane_\K([0-9]+\.[0-9]+\.[0-9]+)(?=~upstream-1_all\.deb)')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The installed version string includes "~upstream-1" so stripping this will leave each install seeming to need an update:
[+] freeplane (1.12.11~upstream-1) has an update pending. 1.12.11 is available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to also add freeplane
to the repository manifest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add freeplane to the manifest file
Hi @philclifford , thank you for your help with this PR! I made the change the manifest that you requested. Let me know if anything else needs improving. |
You're very welcome. Thanks for your contribution. |
closes #1451