Refactor: properly handle callable array even when options are missing #1371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved handling for cases where `$callable` is an array but does not include the `$callable['options']` key. In such cases, the default options are preserved and no errors occur. Also streamlined the normalization logic by explicitly checking for valid entries (`!empty()`)
|
@matteotrubini can you add some test cases for this? |
Expanded MarkupManagerTest to cover registration and validation of Twig functions, including handling of options, default options, empty callables, and invalid callables.
LukeTowers
added
the
needs review
|
@LukeTowers, once I get your green light, I’ll proceed with makeTwigFilters() as described in the first comment. |
|
@matteotrubini ideally the options logic that's present everywhere in Winter could be centralized to a helper as much as possible. Should be good to proceed with the makeTwigFilters |
matteotrubini
force-pushed
the
markupmanager-makeTwig-callable
branch
from
ed98069 to
4f88f25
Compare
matteotrubini
force-pushed
the
markupmanager-makeTwig-callable
branch
from
39e3d0c to
21c9cbd
Compare
|
I have finished my review and the tests are green. I would squash the commits before marking the PR as ready - what do you think, @LukeTowers? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved handling for cases where
$callableis an array but does not include the$callable['options']key. In such cases, the default options are preserved and no errors occur.Also streamlined the normalization logic by explicitly checking for valid entries (
!empty())makeTwigFilters()function as well for consistency.Eventually, both implementations could be unified into a shared helper, as they follow the same logic.