Skip to content

fix: warning about DYLIB_CURRENT_VERSION getting truncated #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

typfel
Copy link
Member

@typfel typfel commented Jul 22, 2025

What's new in this PR

When build the Swift bindings we get the following warning:

warning build: Truncating -current_version to fit in 32-bit space used by old mach-o format

This is because the DYLIB_CURRENT_VERSION is now larger (80000) than 65535, which is the calculated as major * 10000 + minor * 100 + patch.

We shouldn't convert our version into single integer but rather keep it as is since the acceptable format for this version is xxxx.yy.zz.


PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@typfel typfel requested a review from a team as a code owner July 22, 2025 12:39
Copy link

github-actions bot commented Jul 22, 2025

🐰 Bencher Report

Branchfix/library-version-warning
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
Commit add f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
17,407.00 µs
Commit add f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
733.01 µs
Commit add f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
4,208.60 µs
Commit add f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
7,598.80 µs
Commit add f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
11,521.00 µs
Commit add f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
14,287.00 µs
Commit add f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
987,600.00 µs
Commit add f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
716.65 µs
Commit add f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
79,376.00 µs
Commit add f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
216,330.00 µs
Commit add f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
424,620.00 µs
Commit add f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
679,430.00 µs
Commit pending proposals f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
115,800.00 µs
Commit pending proposals f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
23,044.00 µs
Commit pending proposals f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
41,643.00 µs
Commit pending proposals f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
57,682.00 µs
Commit pending proposals f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
76,781.00 µs
Commit pending proposals f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
95,040.00 µs
Commit pending proposals f(pending size)/cs1/mem/1📈 view plot
🚷 view threshold
17,186.00 µs
Commit pending proposals f(pending size)/cs1/mem/101📈 view plot
🚷 view threshold
115,900.00 µs
Commit pending proposals f(pending size)/cs1/mem/21📈 view plot
🚷 view threshold
34,586.00 µs
Commit pending proposals f(pending size)/cs1/mem/41📈 view plot
🚷 view threshold
56,558.00 µs
Commit pending proposals f(pending size)/cs1/mem/61📈 view plot
🚷 view threshold
76,121.00 µs
Commit pending proposals f(pending size)/cs1/mem/81📈 view plot
🚷 view threshold
95,348.00 µs
Commit remove f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
11,421.00 µs
Commit remove f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
595.50 µs
Commit remove f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
2,264.30 µs
Commit remove f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
4,073.70 µs
Commit remove f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
6,330.20 µs
Commit remove f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
8,239.70 µs
Commit remove f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
15,289.00 µs
Commit remove f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
135,220.00 µs
Commit remove f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
111,300.00 µs
Commit remove f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
87,139.00 µs
Commit remove f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
62,598.00 µs
Commit remove f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
39,746.00 µs
Commit update f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
134,930.00 µs
Commit update f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
788.86 µs
Commit update f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
28,301.00 µs
Commit update f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
55,353.00 µs
Commit update f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
83,167.00 µs
Commit update f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
108,900.00 µs
🐰 View full continuous benchmarking report in Bencher

When build the Swift bindings we get the following warning:

```
warning build: Truncating -current_version to fit in 32-bit space used by old mach-o format
```

This is because the DYLIB_CURRENT_VERSION is now larger (80000) than 65535, which is
the calculated as major * 10000 + minor * 100 + patch.

We shouldn't convert our version into single integer but rather keep it as is since
the acceptable format for this version is xxxx.yy.zz.
@typfel typfel force-pushed the fix/library-version-warning branch from 198e0fa to 47d49d5 Compare July 23, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants