Skip to content

fix: cancel btn not working on the sso redirect from domain [WPB-15673] 🍒 #3885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-15673 [Android] "Cancel" button not working in the "Redirect to an on-premises backend" popup


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

cancel btn not working on the sso redirect from domain

Solutions

update the state to remove the dialog

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/XS labels Feb 20, 2025
Copy link

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.49%. Comparing base (e942709) to head (53429f3).

Files with missing lines Patch % Lines
...d/ui/authentication/login/sso/LoginSSOViewModel.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3885      +/-   ##
===========================================
- Coverage    45.50%   45.49%   -0.01%     
===========================================
  Files          491      491              
  Lines        17079    17080       +1     
  Branches      2854     2854              
===========================================
  Hits          7771     7771              
- Misses        8513     8514       +1     
  Partials       795      795              
Files with missing lines Coverage Δ
...d/ui/authentication/login/sso/LoginSSOViewModel.kt 73.15% <0.00%> (-0.50%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e942709...53429f3. Read the comment docs.

Copy link
Contributor Author

Built wire-android-staging-compat-pr-3885.apk is available for download

Copy link
Contributor Author

Built wire-android-dev-debug-pr-3885.apk is available for download

@MohamadJaara MohamadJaara added this pull request to the merge queue Feb 24, 2025
Merged via the queue into develop with commit b303414 Feb 24, 2025
11 of 12 checks passed
@MohamadJaara MohamadJaara deleted the fix/button-not-working-in-the-Redirect-to-an-on-premises-backend-popup-cherry-pick branch February 24, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants