chore(logging): guarantee app metadata in log files [WPB-8645] 🍒 #3906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Most of the times, we don't get basic app information when reading the log files.
Causes
We launch an async coroutine that will initialise the
LogFileWriter
, and immediately log basic app information, like App version, OS version, Phone model, Commit hash, etc.Solutions
Make it so that
LogFileWriter.start()
suspends until it actually starts. Then we can start printing basic information.This is done by waiting for the first log lines to come before completing the
LogFileWriter.start
.PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.