fix: disable in-call reactions while connecting [WPB-16372]

[saleniuk]

WPB-16372 [Android] In-call Reactions can be sent while user is still in a connecting state

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

The user is able to send in-call reactions while still in the "Connecting" state, despite not having joined the call yet.

Solutions

Disable in-call reactions button while in the "Connecting" state.

Testing

How to Test

Join the call and try to click in-call reactions button while in the "Connecting" state.

Attachments (Optional)

call_reactions_when_connecting.mp4

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[MohamadJaara]

the fix version is 4.11 aka release/candidate, other than this LGTM

[github-actions]

Built wire-android-staging-compat-pr-3915.apk is available for download

[github-actions]

Built wire-android-dev-debug-pr-3915.apk is available for download

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 27.77778% with 13 lines in your changes missing coverage. Please review.

Project coverage is 45.59%. Comparing base (0a20227) to head (82d843b).

Files with missing lines	Patch %	Lines
...tlin/com/wire/android/migration/MigrationMapper.kt	0.00%	4 Missing ⚠️
...re/android/notification/CallNotificationManager.kt	0.00%	2 Missing ⚠️
.../wire/android/ui/calling/SharedCallingViewModel.kt	0.00%	2 Missing ⚠️
...ome/conversationslist/ConversationListViewModel.kt	33.33%	2 Missing ⚠️
...tionslist/filter/ConversationFilterSheetContent.kt	0.00%	2 Missing ⚠️
.../wire/android/util/debug/FeatureVisibilityFlags.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                  Coverage Diff                  @@
##           release/candidate    #3915      +/-   ##
=====================================================
- Coverage              45.59%   45.59%   -0.01%     
=====================================================
  Files                    491      491              
  Lines                  17078    17087       +9     
  Branches                2845     2851       +6     
=====================================================
+ Hits                    7786     7790       +4     
- Misses                  8500     8505       +5     
  Partials                 792      792              

Files with missing lines	Coverage Δ
...me/conversations/info/ConversationInfoViewState.kt	100.00% <100.00%> (ø)
...tions/usecase/GetConversationsFromSearchUseCase.kt	81.81% <100.00%> (+0.33%)	⬆️
...ome/conversationslist/model/ConversationsSource.kt	86.66% <100.00%> (+2.05%)	⬆️
.../wire/android/util/debug/FeatureVisibilityFlags.kt	0.00% <0.00%> (ø)
...re/android/notification/CallNotificationManager.kt	39.08% <0.00%> (ø)
.../wire/android/ui/calling/SharedCallingViewModel.kt	69.93% <0.00%> (ø)
...ome/conversationslist/ConversationListViewModel.kt	33.21% <33.33%> (+<0.01%)	⬆️
...tionslist/filter/ConversationFilterSheetContent.kt	0.00% <0.00%> (ø)
...tlin/com/wire/android/migration/MigrationMapper.kt	4.37% <0.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a20227...82d843b. Read the comment docs.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Built wire-android-staging-compat-pr-3915.apk is available for download