Skip to content

fix: disable in-call reactions while connecting [WPB-16372] #3916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Mar 14, 2025

TaskWPB-16372 [Android] In-call Reactions can be sent while user is still in a connecting state


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

The user is able to send in-call reactions while still in the "Connecting" state, despite not having joined the call yet.

Solutions

Disable in-call reactions button while in the "Connecting" state.

Testing

How to Test

Join the call and try to click in-call reactions button while in the "Connecting" state.

Attachments (Optional)

image
call_reactions_when_connecting.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk saleniuk requested a review from MohamadJaara March 14, 2025 17:14
@saleniuk saleniuk requested review from a team, typfel, vitorhugods, mathias-niboulies and emmaoke-w and removed request for a team March 14, 2025 17:14
Copy link

Copy link
Contributor

Built wire-android-staging-compat-pr-3916.apk is available for download

@MohamadJaara MohamadJaara added this pull request to the merge queue Mar 18, 2025
Merged via the queue into release/candidate with commit ca62a1a Mar 18, 2025
13 of 14 checks passed
@MohamadJaara MohamadJaara deleted the fix/call-reactions-disabled-when-connecting branch March 18, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants