-
Notifications
You must be signed in to change notification settings - Fork 41
fix: persist self email to register device with 2fa [WPB-16573] #3929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…into fix/login-with-email-and-2fa
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3929 +/- ##
=====================================================
+ Coverage 45.74% 45.77% +0.02%
=====================================================
Files 492 492
Lines 17097 17105 +8
Branches 2845 2847 +2
=====================================================
+ Hits 7821 7829 +8
Misses 8483 8483
Partials 793 793
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Built wire-android-staging-compat-pr-3929.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When registering device with 2fa, the code is saved from login so that it can be reused, but it uses email as the key.
Currently, the app doesn't know self user's email until initial sync is performed (only then fetchSelfUser is executed) so when trying to get email during device registration, it returns null and 2fa code cannot be retrieved resulting in error.
Solutions
Persist self user email (in User table but with flag informing that this user's data is incomplete) right after login and when the user session is created so that it can be used during client registration.
In this PR also
LoginEmailViewModelTest
got updated to useArrangement
.Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Login with email on account that requires 2FA.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.