Skip to content

fix: app crashing when sharing location form a modified version of android [WPB-11304] 🍒 #3939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-11304 [Android] C apps on ss4sk device crashing when sharing location


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

app crashing when sharing location form a modified version of android

Causes (Optional)

location service is removed from the OS

Solutions

try catch

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/XS labels Mar 26, 2025
@yamilmedina yamilmedina enabled auto-merge March 26, 2025 16:25
Copy link

@yamilmedina yamilmedina added this pull request to the merge queue Mar 26, 2025
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 45.83%. Comparing base (74d4c15) to head (c4357d0).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...e/messagecomposer/location/LocationPickerHelper.kt 37.50% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3939      +/-   ##
===========================================
- Coverage    45.84%   45.83%   -0.02%     
===========================================
  Files          495      495              
  Lines        17143    17149       +6     
  Branches      2855     2855              
===========================================
+ Hits          7859     7860       +1     
- Misses        8491     8496       +5     
  Partials       793      793              
Files with missing lines Coverage Δ
...e/messagecomposer/location/LocationPickerHelper.kt 66.66% <37.50%> (-5.27%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74d4c15...c4357d0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor Author

Built wire-android-staging-compat-pr-3939.apk is available for download

Copy link
Contributor Author

Built wire-android-dev-debug-pr-3939.apk is available for download

Merged via the queue into develop with commit 83c0a0e Mar 26, 2025
13 of 14 checks passed
@yamilmedina yamilmedina deleted the fix/ss4k-location-crash-cherry-pick branch March 26, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants