Skip to content

fix: analytics should be disabled for c-builds (WPB-16675) 🍒 #3944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-16675 [Android] C app is crashing when sending messages


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Crash while performing actions in the app for custom builds.

Process: com.wire.android.xxxxx, PID: 22097
com.goterl.resourceloader.ResourceLoaderException: lateinit property coroutineScope has not been initialized
	at com.wire.android.feature.analytics.AnonymousAnalyticsManagerImpl.sendEvent(Unknown Source:8)
	at com.wire.android.ui.home.conversations.sendmessage.SendMessageViewModel.handleAssetContributionEvent(Unknown Source:47)
                                                                            access$handleAssetContributionEvent
	at com.wire.android.ui.home.conversations.sendmessage.SendMessageViewModel$sendAttachment$1$1.invokeSuspend(Unknown Source:335)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(Unknown Source:8)
	at kotlinx.coroutines.DispatchedTask.run(Unknown Source:98)
	at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(Unknown Source:81)
	at kotlinx.coroutines.scheduling.TaskImpl.run(Unknown Source:2)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(Unknown Source:92)
                                                            executeTask
                                                            runWorker
                                                            run
	Suppressed: pi.e: [z0{Cancelling}@28484bb, Dispatchers.Main.immediate]

Causes (Optional)

Analytics dependency was added before resolving custom builds config

Solutions

Consider if we are building a custom app to just disable the analytics. This might be tweaked later if we need to.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

N/A


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/XS labels Mar 27, 2025
@yamilmedina yamilmedina enabled auto-merge March 31, 2025 08:26
Copy link

@yamilmedina yamilmedina added this pull request to the merge queue Mar 31, 2025
Merged via the queue into develop with commit 62cde60 Mar 31, 2025
12 of 14 checks passed
@yamilmedina yamilmedina deleted the fix/analytics-cbuilds-cherry-pick branch March 31, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants