Skip to content

fix: make sure coroutine is init before using it on analytics manager [WPB-17078] 🍒 #3980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 9, 2025

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-17078 [Android] play store crash related to countly


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

It seems there is a case where we are trying to access the coroutine scope and this is not init.

Causes (Optional)

Edge case of init not being called ?

Solutions

Just check for the coroutine to be init before accessing it.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/XS labels Apr 9, 2025
@yamilmedina yamilmedina enabled auto-merge April 9, 2025 11:36
@yamilmedina yamilmedina requested review from yamilmedina, a team, typfel, sbakhtiarov, alexandreferris and ohassine and removed request for a team April 9, 2025 11:37
Copy link

sonarqubecloud bot commented Apr 9, 2025

Copy link
Contributor Author

github-actions bot commented Apr 9, 2025

Built wire-android-staging-compat-pr-3980.apk is available for download

Copy link
Contributor Author

github-actions bot commented Apr 9, 2025

Built wire-android-dev-debug-pr-3980.apk is available for download

@yamilmedina yamilmedina requested a review from MohamadJaara April 9, 2025 15:22
@yamilmedina yamilmedina added this pull request to the merge queue Apr 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2025
@yamilmedina yamilmedina added this pull request to the merge queue Apr 9, 2025
Merged via the queue into develop with commit 014d90d Apr 9, 2025
13 of 14 checks passed
@yamilmedina yamilmedina deleted the fix/analytics-scopecortouine-check-cherry-pick branch April 9, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants