-
Notifications
You must be signed in to change notification settings - Fork 41
fix: schema validation for attachments - rc (WPB-17546) #4016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #4016 +/- ##
==================================================
Coverage 45.91% 45.92%
==================================================
Files 492 492
Lines 17174 17192 +18
Branches 2862 2864 +2
==================================================
+ Hits 7886 7895 +9
- Misses 8491 8499 +8
- Partials 797 798 +1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Built wire-android-staging-compat-pr-4016.apk is available for download |
|
Built wire-android-staging-compat-pr-4016.apk is available for download |
Cherry-pick of:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Extra handling needed for the app about sharing attachments, to be more restrict about what can be shared or not
Solutions
Deny the usage of
file://
schema. We don't need it in the app, we use as supposed to content resolvers for it.Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.