Skip to content

fix: Location service crash on custom devices [WPB-18457] #4095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2025

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Jul 2, 2025

BugWPB-18457 [Android] (Reproducible only on ss4sk device)Share Location feature crashes the Wire Bund app upon selection


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

if the location api is missing

Causes (Optional)

modified ROMs that have this service removed

Solutions

try catch it

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara requested review from ohassine and saleniuk July 2, 2025 16:27
@MohamadJaara MohamadJaara changed the title location fix: Location service crah on custom devces Jul 2, 2025
@MohamadJaara MohamadJaara changed the title fix: Location service crah on custom devces fix: Location service crash on custom devces Jul 2, 2025
Copy link

sonarqubecloud bot commented Jul 3, 2025

@MohamadJaara MohamadJaara changed the title fix: Location service crash on custom devces fix: Location service crash on custom devices [WPB-18457] Jul 3, 2025
Copy link
Contributor

github-actions bot commented Jul 3, 2025

Built wire-android-staging-compat-pr-4095.apk is available for download

@MohamadJaara MohamadJaara merged commit b7bfd81 into release/candidate Jul 4, 2025
24 of 28 checks passed
@MohamadJaara MohamadJaara deleted the mo/fix/location-service-crash branch July 4, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants