Skip to content

feat: script to organize the apk [WPB-18583] #4102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2025

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Jul 4, 2025

TaskWPB-18583 [Android] Write script that adjusts Wire apks


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

a script for testing and QA that decompiles the apk change classes placement and then compile it again

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@MohamadJaara MohamadJaara changed the base branch from develop to release/candidate July 4, 2025 12:54
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Jul 4, 2025
@MohamadJaara MohamadJaara requested a review from Copilot July 4, 2025 12:55
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new Bash script to decompile a Wire APK, relocate the com/wire smali folder, rebuild and optionally sign the APK, plus accompanying documentation.

  • Introduces wire_apk_wrapper.sh to automate decompilation, folder move, rebuild, validation, and signing.
  • Adds README_APK_WRAPPER.md detailing prerequisites, usage, and script internals.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
scripts/wire_apk_wrapper.sh New wrapper script to decompile, reorganize, rebuild, validate, and sign APKs
scripts/README_APK_WRAPPER.md Documentation for script prerequisites, usage, features, and troubleshooting
Comments suppressed due to low confidence (2)

scripts/README_APK_WRAPPER.md:20

  • The script actually uses apksigner for signing rather than jarsigner. Please update this section to reference apksigner to avoid confusion.
- **Purpose**: Needed for running apktool and jarsigner

scripts/wire_apk_wrapper.sh:1

  • [nitpick] There are no automated tests included for the wrapper script. Consider adding unit or integration tests around key functions (e.g., check_dependencies, path moves, rebuilds) to ensure future changes are validated.
#!/bin/bash

@MohamadJaara MohamadJaara changed the title feat: script to reorgnize the apk feat: script to organize the apk [WPB-18583] Jul 4, 2025
@MohamadJaara MohamadJaara requested a review from sbakhtiarov July 7, 2025 07:40
Copy link
Contributor

github-actions bot commented Jul 7, 2025

Built wire-android-staging-compat-pr-4102.apk is available for download

Copy link

sonarqubecloud bot commented Jul 7, 2025

Copy link
Contributor

github-actions bot commented Jul 7, 2025

Built wire-android-staging-compat-pr-4102.apk is available for download

@MohamadJaara MohamadJaara enabled auto-merge July 8, 2025 09:15
@MohamadJaara MohamadJaara added this pull request to the merge queue Jul 15, 2025
Merged via the queue into release/candidate with commit 4b73548 Jul 15, 2025
13 of 14 checks passed
@MohamadJaara MohamadJaara deleted the mo/feat/script-to-reorgnize-the-apk branch July 15, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants