-
Notifications
You must be signed in to change notification settings - Fork 41
feat: script to organize the apk [WPB-18583] #4102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: script to organize the apk [WPB-18583] #4102
Conversation
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a new Bash script to decompile a Wire APK, relocate the com/wire
smali folder, rebuild and optionally sign the APK, plus accompanying documentation.
- Introduces
wire_apk_wrapper.sh
to automate decompilation, folder move, rebuild, validation, and signing. - Adds
README_APK_WRAPPER.md
detailing prerequisites, usage, and script internals.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
scripts/wire_apk_wrapper.sh | New wrapper script to decompile, reorganize, rebuild, validate, and sign APKs |
scripts/README_APK_WRAPPER.md | Documentation for script prerequisites, usage, features, and troubleshooting |
Comments suppressed due to low confidence (2)
scripts/README_APK_WRAPPER.md:20
- The script actually uses
apksigner
for signing rather thanjarsigner
. Please update this section to referenceapksigner
to avoid confusion.
- **Purpose**: Needed for running apktool and jarsigner
scripts/wire_apk_wrapper.sh:1
- [nitpick] There are no automated tests included for the wrapper script. Consider adding unit or integration tests around key functions (e.g.,
check_dependencies
, path moves, rebuilds) to ensure future changes are validated.
#!/bin/bash
…EADME_APK_WRAPPER.md
Built wire-android-staging-compat-pr-4102.apk is available for download |
|
Built wire-android-staging-compat-pr-4102.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
a script for testing and QA that decompiles the apk change classes placement and then compile it again
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.