Skip to content

feat: add compile time flag to enable/disable in call reactions [WPB-18894] #4138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 24, 2025

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Jul 23, 2025

TaskWPB-18894 [Android] Turn off in-call reactions at build time for RC


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

add compile time flag to enable/disable in call reactions

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@MohamadJaara MohamadJaara changed the base branch from develop to release/candidate July 23, 2025 08:40
@MohamadJaara MohamadJaara changed the title feat: add compile time flag to enable/disable in call reactions feat: add compile time flag to enable/disable in call reactions [WPB-18894] Jul 23, 2025
Co-authored-by: Oussama Hassine <[email protected]>
@MohamadJaara MohamadJaara requested a review from Copilot July 23, 2025 09:35
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a compile-time feature flag to enable/disable in-call reactions functionality in the Wire Android app, with the feature disabled by default for the RC build.

  • Adds a new configuration flag IN_CALL_REACTIONS_ENABLED that defaults to false
  • Wraps all in-call reactions UI components and functionality with build-time checks
  • Prevents reaction processing and UI rendering when the feature is disabled

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
default.json Adds the in_call_reactions_enabled configuration flag set to false
FeatureConfigs.kt Defines the new IN_CALL_REACTIONS_ENABLED boolean configuration
ParticipantTile.kt Conditionally renders reaction animations based on the feature flag
OngoingCallScreen.kt Guards reaction UI components and processing with feature flag checks
SharedCallingViewModel.kt Prevents reaction observation and sending when feature is disabled
Comments suppressed due to low confidence (1)

Copy link

codecov bot commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.92%. Comparing base (4b73548) to head (c446c25).
Report is 1 commits behind head on release/candidate.

Files with missing lines Patch % Lines
.../wire/android/ui/calling/SharedCallingViewModel.kt 80.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #4138   +/-   ##
==================================================
  Coverage              45.92%   45.92%           
==================================================
  Files                    492      492           
  Lines                  17192    17196    +4     
  Branches                2864     2866    +2     
==================================================
+ Hits                    7895     7898    +3     
- Misses                  8499     8500    +1     
  Partials                 798      798           
Files with missing lines Coverage Δ
...alling/ongoing/participantsview/ParticipantTile.kt 0.00% <ø> (ø)
.../wire/android/ui/calling/SharedCallingViewModel.kt 70.05% <80.00%> (+0.12%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b73548...c446c25. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@MohamadJaara MohamadJaara added this pull request to the merge queue Jul 24, 2025
Merged via the queue into release/candidate with commit 82ddfc7 Jul 24, 2025
13 of 14 checks passed
@MohamadJaara MohamadJaara deleted the mo/feat/disable-in-call-reactions branch July 24, 2025 10:26
Copy link
Contributor

Built wire-android-staging-compat-pr-4138.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants