-
Notifications
You must be signed in to change notification settings - Fork 41
feat: add compile time flag to enable/disable in call reactions [WPB-18894] #4138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add compile time flag to enable/disable in call reactions [WPB-18894] #4138
Conversation
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
app/src/main/kotlin/com/wire/android/ui/calling/SharedCallingViewModel.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Oussama Hassine <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a compile-time feature flag to enable/disable in-call reactions functionality in the Wire Android app, with the feature disabled by default for the RC build.
- Adds a new configuration flag
IN_CALL_REACTIONS_ENABLED
that defaults tofalse
- Wraps all in-call reactions UI components and functionality with build-time checks
- Prevents reaction processing and UI rendering when the feature is disabled
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
default.json | Adds the in_call_reactions_enabled configuration flag set to false |
FeatureConfigs.kt | Defines the new IN_CALL_REACTIONS_ENABLED boolean configuration |
ParticipantTile.kt | Conditionally renders reaction animations based on the feature flag |
OngoingCallScreen.kt | Guards reaction UI components and processing with feature flag checks |
SharedCallingViewModel.kt | Prevents reaction observation and sending when feature is disabled |
Comments suppressed due to low confidence (1)
app/src/main/kotlin/com/wire/android/ui/calling/SharedCallingViewModel.kt
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #4138 +/- ##
==================================================
Coverage 45.92% 45.92%
==================================================
Files 492 492
Lines 17192 17196 +4
Branches 2864 2866 +2
==================================================
+ Hits 7895 7898 +3
- Misses 8499 8500 +1
Partials 798 798
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Built wire-android-staging-compat-pr-4138.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
add compile time flag to enable/disable in call reactions
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.