-
Notifications
You must be signed in to change notification settings - Fork 41
feat: disable read recipt for mls [WPB-18896] #4139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable read recipt for mls [WPB-18896] #4139
Conversation
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request disables read receipt functionality for MLS (Messaging Layer Security) conversations across the Wire Android app. The primary purpose is to hide read receipt options in the UI when MLS protocol is being used, as part of ticket WPB-18896.
Key changes implemented:
- Hide read receipt options during group creation for MLS conversations
- Remove read receipt tab from message details for MLS conversations
- Disable read receipt settings in existing MLS group conversation options
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
GroupOptionsScreen.kt | Conditionally hides read receipt option during new group creation based on MLS protocol |
NewConversationViewModel.kt | Forces read receipts to false for MLS groups during conversation creation |
MessageDetailsViewModel.kt | Adds protocol detection to determine if conversation uses MLS |
MessageDetailsState.kt | Adds protocol info field to track conversation protocol type |
MessageDetailsScreen.kt | Hides read receipts tab in message details for MLS conversations |
GroupConversationOptions.kt | Conditionally hides read receipt settings for existing MLS groups |
GroupConversationDetailsViewModel.kt | Prevents read receipt updates and disables UI controls for MLS conversations |
Comments suppressed due to low confidence (3)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #4139 +/- ##
=====================================================
- Coverage 45.92% 45.88% -0.05%
=====================================================
Files 492 492
Lines 17196 17213 +17
Branches 2866 2870 +4
=====================================================
Hits 7898 7898
- Misses 8500 8515 +15
- Partials 798 800 +2
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Built wire-android-staging-compat-pr-4139.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
isable read recipt for mls
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.