Skip to content

feat: disable read recipt for mls [WPB-18896] #4139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 24, 2025

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Jul 23, 2025

TaskWPB-18896 [Android] Hide MLS Read Receipts in UI for 4.11.x


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

isable read recipt for mls

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara changed the base branch from develop to release/candidate July 23, 2025 09:31
Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request disables read receipt functionality for MLS (Messaging Layer Security) conversations across the Wire Android app. The primary purpose is to hide read receipt options in the UI when MLS protocol is being used, as part of ticket WPB-18896.

Key changes implemented:

  • Hide read receipt options during group creation for MLS conversations
  • Remove read receipt tab from message details for MLS conversations
  • Disable read receipt settings in existing MLS group conversation options

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
GroupOptionsScreen.kt Conditionally hides read receipt option during new group creation based on MLS protocol
NewConversationViewModel.kt Forces read receipts to false for MLS groups during conversation creation
MessageDetailsViewModel.kt Adds protocol detection to determine if conversation uses MLS
MessageDetailsState.kt Adds protocol info field to track conversation protocol type
MessageDetailsScreen.kt Hides read receipts tab in message details for MLS conversations
GroupConversationOptions.kt Conditionally hides read receipt settings for existing MLS groups
GroupConversationDetailsViewModel.kt Prevents read receipt updates and disables UI controls for MLS conversations
Comments suppressed due to low confidence (3)

@MohamadJaara MohamadJaara enabled auto-merge July 24, 2025 09:47
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 9.52381% with 19 lines in your changes missing coverage. Please review.

Project coverage is 45.88%. Comparing base (ef10384) to head (c8eb8f3).
Report is 1 commits behind head on release/candidate.

Files with missing lines Patch % Lines
...rsations/messagedetails/MessageDetailsViewModel.kt 0.00% 13 Missing ⚠️
...tions/details/GroupConversationDetailsViewModel.kt 33.33% 1 Missing and 1 partial ⚠️
...onversations/messagedetails/MessageDetailsState.kt 0.00% 2 Missing ⚠️
...i/home/newconversation/NewConversationViewModel.kt 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #4139      +/-   ##
=====================================================
- Coverage              45.92%   45.88%   -0.05%     
=====================================================
  Files                    492      492              
  Lines                  17196    17213      +17     
  Branches                2866     2870       +4     
=====================================================
  Hits                    7898     7898              
- Misses                  8500     8515      +15     
- Partials                 798      800       +2     
Files with missing lines Coverage Δ
...tions/details/GroupConversationDetailsViewModel.kt 63.63% <33.33%> (-0.65%) ⬇️
...onversations/messagedetails/MessageDetailsState.kt 0.00% <0.00%> (ø)
...i/home/newconversation/NewConversationViewModel.kt 66.94% <33.33%> (-1.13%) ⬇️
...rsations/messagedetails/MessageDetailsViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef10384...c8eb8f3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@MohamadJaara MohamadJaara added this pull request to the merge queue Jul 24, 2025
Merged via the queue into release/candidate with commit a4b4e1d Jul 24, 2025
13 of 14 checks passed
@MohamadJaara MohamadJaara deleted the mo/feat/disable-read-recipt-for-MLS branch July 24, 2025 10:58
Copy link
Contributor

Built wire-android-staging-compat-pr-4139.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants