Skip to content

fix: crash on logout [WPB-18706] 🍒 #4150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-18706 [Android] Crash when account was deleted or device was removed

https://wearezeta.atlassian.net/browse/WPB-18706

What's new in this PR?

Issues

Application crash when current client is deleted from other device.

Causes (Optional)

  1. Current client removal triggers logout and clears data.
  2. Data clear resets the "initialSyncCompleted" flag and HomeViewModel navigates to InitialSyncScreen.
  3. This screen is not supposed to be called with no session and crashes on dependencies setup.

Solutions

Check current session availability in HomeViewModel before navigating to InitialSyncScreen.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/XS labels Jul 29, 2025
Copy link

@yamilmedina yamilmedina requested review from a team, typfel, vitorhugods, Garzas, ohassine and emmaoke-w and removed request for a team August 4, 2025 08:13
@yamilmedina yamilmedina self-requested a review August 4, 2025 08:13
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbakhtiarov the cherry-pick found some conflicts we need to address 🫤

Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to fix conflicts before merge to develop, since the cherry-pick action failed

@sbakhtiarov sbakhtiarov deleted the fix/crash-on-logout-cherry-pick branch August 15, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants