-
Notifications
You must be signed in to change notification settings - Fork 40
fix: resend code timer [WPB-18364] 🍒 #4158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
const val DEFAULT_VERIFICATION_CODE_LENGTH = 6 | ||
} | ||
} | ||
>>>>>>> 37030776a (fix: resend code timer [WPB-18364] (#4145)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few conflicts
clickEnabled = !isLoading, | ||
timerText = timerText, | ||
) | ||
>>>>>>> 37030776a (fix: resend code timer [WPB-18364] (#4145)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too
every { coreLogic.getSessionScope(any()).logout } returns logoutUseCase | ||
every { coreLogic.getGlobalScope().deleteSession } returns deleteSessionUseCase | ||
every { coreLogic.getGlobalScope().session.updateCurrentSession } returns updateCurrentSessionUseCase | ||
every { coreLogic.getGlobalScope().session.currentSession } returns currentSessionUseCase | ||
coEvery { currentSessionUseCase() } returns CurrentSessionResult.Success(AccountInfo.Valid(USER_ID)) | ||
======= | ||
coEvery { countdownTimer.start(any(), any(), any()) } returns Unit | ||
>>>>>>> 37030776a (fix: resend code timer [WPB-18364] (#4145)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR needs to fix conflicts before merge to develop, since the cherry-pick action failed
Superseded by #4145 |
This PR was automatically cherry-picked based on the following PR:
Original PR description:
https://wearezeta.atlassian.net/browse/WPB-18364
What's new in this PR?
Issues
"Resend Code" button allows user to request 2FA codes more frequent than allowed by server rate limitation.
Solutions
Disable "Resend Code" button for 5 minutes after requesting 2FA code.