Skip to content

fix: resend code timer [WPB-18364] 🍒 #4158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 4, 2025

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-18364 [Android]Resend code button on verification screen of Next-Column-3 is not clickable

https://wearezeta.atlassian.net/browse/WPB-18364

What's new in this PR?

Issues

"Resend Code" button allows user to request 2FA codes more frequent than allowed by server rate limitation.

Solutions

Disable "Resend Code" button for 5 minutes after requesting 2FA code.

resend_code_timer

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/S labels Aug 4, 2025
Copy link

sonarqubecloud bot commented Aug 4, 2025

const val DEFAULT_VERIFICATION_CODE_LENGTH = 6
}
}
>>>>>>> 37030776a (fix: resend code timer [WPB-18364] (#4145))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few conflicts

clickEnabled = !isLoading,
timerText = timerText,
)
>>>>>>> 37030776a (fix: resend code timer [WPB-18364] (#4145))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too

every { coreLogic.getSessionScope(any()).logout } returns logoutUseCase
every { coreLogic.getGlobalScope().deleteSession } returns deleteSessionUseCase
every { coreLogic.getGlobalScope().session.updateCurrentSession } returns updateCurrentSessionUseCase
every { coreLogic.getGlobalScope().session.currentSession } returns currentSessionUseCase
coEvery { currentSessionUseCase() } returns CurrentSessionResult.Success(AccountInfo.Valid(USER_ID))
=======
coEvery { countdownTimer.start(any(), any(), any()) } returns Unit
>>>>>>> 37030776a (fix: resend code timer [WPB-18364] (#4145))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

@yamilmedina yamilmedina self-requested a review August 8, 2025 09:19
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to fix conflicts before merge to develop, since the cherry-pick action failed

@yamilmedina
Copy link
Contributor

Superseded by #4145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants