Skip to content

fix: user doesn't see anyone else in MLS call [WPB-19454] #4181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Aug 13, 2025

BugWPB-19454 [Android] Participants not visible to each other in channel conversation group calls


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When user joins a group call from a MLS group or channel, doesn't see anyone else, it looks like he/she is alone in the call but for instance reactions sent by someone else are visible to that user.

Solutions

Update kalium ref to use the version that contains the fix for that:
wireapp/kalium#3579

Dependencies (Optional)

Needs releases with:

Testing

How to Test

Join a group call from a MLS group or channel.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

@saleniuk looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
fcf74fb198dc1f0d7d3862aad560229c7485c0a2 848223899dd74f555886b1ab5548e39ef6428d00

Is this intentional?

Copy link

@saleniuk saleniuk requested a review from Copilot August 14, 2025 07:45
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a bug where users joining MLS group or channel calls don't see other participants, despite being able to see their reactions. The fix updates the kalium submodule reference to include upstream changes that resolve this visibility issue.

  • Updates kalium submodule to commit 848223899dd74f555886b1ab5548e39ef6428d00
  • Fixes MLS call participant visibility issue
  • Resolves bug where users appear alone in group calls despite other participants being present

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@saleniuk saleniuk requested review from a team, MohamadJaara, vitorhugods, Garzas, ohassine and emmaoke-w and removed request for a team August 14, 2025 07:46
@saleniuk saleniuk added this pull request to the merge queue Aug 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 14, 2025
@saleniuk saleniuk added this pull request to the merge queue Aug 14, 2025
Merged via the queue into develop with commit 77a2126 Aug 14, 2025
19 of 21 checks passed
@saleniuk saleniuk deleted the fix/alone-in-a-mls-call branch August 14, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants