test: new member messaging critical flow test (WPB-19322) #4182
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4182 +/- ##
========================================
Coverage 47.66% 47.66%
========================================
Files 510 510
Lines 17463 17463
Branches 2868 2868
========================================
Hits 8324 8324
Misses 8279 8279
Partials 860 860 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
emmaoke-w
requested review from
CinnamonNinja,
yamilmedina,
saleniuk and
sbakhtiarov
|
|
||
| @Suppress("CyclomaticComplexMethod", "LongMethod") | ||
| @Test | ||
| fun givenUserJoinsNewTeam_whenMessagingAndMentionedInGroup_thenReceivesMessagesAndMentions() { |
There was a problem hiding this comment.
this name seems to be very long. can we shorten it maybe to something like MessagingAndMentionTestNewUser or similar?
There was a problem hiding this comment.
This naming convention was proposed by Yamil.
| } | ||
|
|
||
| pages.conversationViewPage.apply { | ||
| typeMessageInInputField("Hello Team Owner") |
There was a problem hiding this comment.
does it make sense to add a step here before to check if new conversation is created and visible in foreground, before you try to send a message? Sometimes this can take a bit and I am not sure how long the test would wait before it would try to send this message.
There was a problem hiding this comment.
Step added as proposed. Thanks
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Adapt new member messaging test for critical flow
Adapt function to add member to group conversation
Adapt function to exchange message
Update test method definition to follow given when then format
Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
New member messaging test for critical flow
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.