Skip to content

fix: disable resend code button (cherrypick from rc) (#WPB-18364) #4194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2025

Conversation

sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented Aug 15, 2025

BugWPB-18364 [Android]Resend code button on verification screen of Next-Column-3 is not clickable

This PR was automatically cherry-picked based on the following PR:


What's new in this PR?

Issues

"Resend Code" button allows user to request 2FA codes more frequent than allowed by server rate limitation.

Solutions

Disable "Resend Code" button for 5 minutes after requesting 2FA code.

resend_code_timer

@sbakhtiarov sbakhtiarov changed the title fix: disable resend code button (cherrypick from bund) (#WPB-18364) fix: disable resend code button (cherrypick from rc) (#WPB-18364) Aug 15, 2025
@yamilmedina yamilmedina merged commit c1bfb50 into develop Aug 15, 2025
9 checks passed
@yamilmedina yamilmedina deleted the fix/resend-code-timer-merge branch August 15, 2025 11:56
Copy link

Copy link

codecov bot commented Aug 15, 2025

Codecov Report

❌ Patch coverage is 26.82927% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.66%. Comparing base (69fc6c9) to head (5815306).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...tication/create/code/CreateAccountCodeViewModel.kt 0.00% 12 Missing ⚠️
.../kotlin/com/wire/android/util/ui/CountdownTimer.kt 0.00% 9 Missing ⚠️
...cation/devices/register/RegisterDeviceViewModel.kt 55.55% 4 Missing ⚠️
.../authentication/login/email/LoginEmailViewModel.kt 55.55% 4 Missing ⚠️
...tication/create/code/CreateAccountCodeViewState.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4194      +/-   ##
===========================================
- Coverage    47.70%   47.66%   -0.05%     
===========================================
  Files          509      510       +1     
  Lines        17418    17461      +43     
  Branches      2860     2868       +8     
===========================================
+ Hits          8309     8322      +13     
- Misses        8251     8279      +28     
- Partials       858      860       +2     
Files with missing lines Coverage Δ
...tication/verificationcode/VerificationCodeState.kt 100.00% <100.00%> (ø)
...tication/create/code/CreateAccountCodeViewState.kt 0.00% <0.00%> (ø)
...cation/devices/register/RegisterDeviceViewModel.kt 76.92% <55.55%> (-2.03%) ⬇️
.../authentication/login/email/LoginEmailViewModel.kt 78.83% <55.55%> (-1.17%) ⬇️
.../kotlin/com/wire/android/util/ui/CountdownTimer.kt 0.00% <0.00%> (ø)
...tication/create/code/CreateAccountCodeViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ba91b4...5815306. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants