Skip to content

fix: link Wire-iOS with WireCellsAPI - WPB-17860 #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

samwyndham
Copy link
Contributor

@samwyndham samwyndham commented May 22, 2025

BugWPB-17860 [iOS] Fix crash due to library not loaded

Issue

There is a crash related to linking WireCellsAPI immediately when app opens on release/cycle-3.125 & develop

Library not loaded: @rpath/WireCellsAPI_3E453E69D626BF70_PackageProduct.framework/WireCellsAPI_3E453E69D626BF70_PackageProduct
  Referenced from: <FCACDFF8-3436-3F11-9968-3FDE95491801> /private/var/containers/Bundle/Application/B96AE8ED-C709-41AE-84EC-5381FBF86D0B/Wire.app/Frameworks/WireDataModel.framework/WireDataModel
  Reason: tried: '/Users/samwyndham/Library/Developer/Xcode/DerivedData/wire-ios-mono-fqrnhkhsugrzddgufgdztbdvjwfj/Build/Products/Debug-iphoneos/PackageFrameworks/WireCellsAPI_3E453E69D626BF70_PackageProduct.framework/WireCellsAPI_3E453E69D626BF70_PackageProduct' (no such file), '/private/preboot/Cryptexes/OS/Users/samwyndham/Library/Developer/Xcode/DerivedData/wire-ios-mono-fqrnhkhsugrzddgufgdztbdvjwfj/Build/Products/Debug-iphoneos/PackageFrameworks/WireCellsAPI_3E453E69D626BF70_PackageProduct.framework/WireCellsAPI_3E453E69D626BF70_PackageProduct' (no such file), '/private/var/containers/Bundle/Application/B96AE8ED-C709-41AE-84EC-5381FBF86D0B/Wire.app/Frameworks/WireCellsAPI_3E453E69D626BF
dyld config: DYLD_LIBRARY_PATH=/usr/lib/system/introspection DYLD_INSERT_LIBRARIES=/usr/lib/libLogRedirect.dylib:/usr/lib/libBacktraceRecording.dylib:/usr/lib/libMainThreadChecker.dylib:/usr/lib/libRPAC.dylib:/usr/lib/libViewDebuggerSupport.dylib

This PR links Wire-iOS to WireCellsAPI which fixes the issue. I'm not sure if there is a better way of addressing this.

I have tested this both on simulator and device builds from Xcode.

A edge build will be available here: https://github.com/wireapp/wire-ios/actions/runs/15189376088

Testing

Run the app. It shouldn't crash immediately.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@samwyndham samwyndham changed the title Link Wire-iOS with WireCellsAPI Link Wire-iOS with WireCellsAPI - WPB-17860 May 22, 2025
@samwyndham samwyndham changed the title Link Wire-iOS with WireCellsAPI - WPB-17860 fix: Link Wire-iOS with WireCellsAPI - WPB-17860 May 22, 2025
@samwyndham samwyndham changed the title fix: Link Wire-iOS with WireCellsAPI - WPB-17860 fix: link Wire-iOS with WireCellsAPI - WPB-17860 May 22, 2025
@samwyndham samwyndham enabled auto-merge (squash) May 22, 2025 14:47
Copy link
Contributor

Test Results

1 813 tests   1 787 ✅  2m 11s ⏱️
  286 suites     26 💤
    1 files        0 ❌

Results for commit 690ad6e.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/wire-cells-api-integration
Commit report: 858bb21
Test service: wire-ios-mono

✅ 0 Failed, 1787 Passed, 26 Skipped, 2m 11.94s Total Time

@samwyndham samwyndham merged commit a734dd3 into release/cycle-3.125 May 22, 2025
18 of 22 checks passed
@samwyndham samwyndham deleted the fix/wire-cells-api-integration branch May 22, 2025 15:34
zenkins pushed a commit that referenced this pull request May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants