-
Notifications
You must be signed in to change notification settings - Fork 20
feat: Disable long-tap (Autofill) for Col1 - WPB-18850 #3377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/cycle-3.120
Are you sure you want to change the base?
Conversation
Test Results 3 files 14 suites 2m 33s ⏱️ Results for commit cce576c. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. It is a shame to have to use a base class for this but I don't think there is a better solution.
|
||
private let isContextMenuAllowed: Bool | ||
|
||
public init(frame: CGRect, isContextMenuAllowed: Bool) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Just to confirm, does this have to be dynamically known or can it be known at compile time. My personal preference would for this kind of functionality to be enabled/disabled per build so that isContextMenuAllowed
parameter is not necessary. I would also argue that product should push for this - perhaps a topic for when we move to scopes.
Issue
It should not be possible to long-tap on an input and select iOS options to fill the text field such as
Currently, long pressing on any input field shows an AutoFill menu (from iOS 17) that redirects to Contacts, Passwords, ScanText options, which should be disabled for Col builds.
https://developer.apple.com/documentation/uikit/uimenu/identifier-swift.struct/autofill
We have several subclasses of the UITextField. This PR contains
ContextMenuControllableTextField
that disabled AutoFill context menu.Testing
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: