feat: Add updates in API v10 - WPB-18970 #3388
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 3 files 276 suites 1m 17s ⏱️ For more details on these failures, see this check. Results for commit f0e9619. |
| @@ -21,4 +21,36 @@ import Foundation | |||
| final class AuthenticationAPIV10: AuthenticationAPIV9 { | |||
|
|
|||
| override var apiVersion: APIVersion { .v10 } | |||
|
|
|||
| override func getDomainRegistration(forEmail email: String) async throws -> DomainRegistrationConfiguration { | |||
| let path = "/get-domain-registration" | |||
There was a problem hiding this comment.
question: I guess we don't need pathPrefix, right?
| @@ -21,4 +21,36 @@ import Foundation | |||
| final class AuthenticationAPIV10: AuthenticationAPIV9 { | |||
|
|
|||
| override var apiVersion: APIVersion { .v10 } | |||
|
|
|||
| override func getDomainRegistration(forEmail email: String) async throws -> DomainRegistrationConfiguration { | |||
There was a problem hiding this comment.
@netbe or @dmitrysimkin do you know the feature where we will use this new endpoint?
|
@dmitrysimkin will you also add tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Added changes for network requests that we use
https://wearezeta.atlassian.net/wiki/spaces/ENGINEERIN/pages/1984856066/API+changes+v9+v10
Testing
Describe how to test.
Optional: attachments like images, videos, etc.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: