fix: making sure keyboard enabled before typetext() - WPB-19174 #3407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findms
changed the title
findms
changed the title
findms
changed the title
Test Results1 862 tests 1 835 ✅ 2m 11s ⏱️ Results for commit 528d40f. ♻️ This comment has been updated with latest results. |
dmitrysimkin
approved these changes
Jul 30, 2025
netbe
reviewed
Jul 30, 2025
| while true { | ||
| let hasKeyboardFocus = (value(forKey: "hasKeyboardFocus") as? Bool) ?? false | ||
| if hasKeyboardFocus { | ||
| break |
There was a problem hiding this comment.
question: not sure to get the logic, if the keyboard is onfocus we don't type?
There was a problem hiding this comment.
No, in this just make sure the keyboard is enabled and the chain function typeText() perform the type action.
| tap() | ||
|
|
||
| if Date().timeIntervalSince(startTime) > timeout { | ||
| XCTFail("Failed to focus keyboard on element within \(timeout) seconds") |
There was a problem hiding this comment.
question: does this actually fail? My guess this is not preventing from continuing execution, to check. Alternative would be to throw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Please describe the issue.
Optional: add details about technical approach, solutions etc.
Optional: reference dependencies to other pull requests etc.
Testing
Describe how to test.
Optional: attachments like images, videos, etc.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: