Skip to content

chore: update CoreCrypto 8.0 - WPB-18877 #3421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: release/cycle-4.2
Choose a base branch
from
Open

chore: update CoreCrypto 8.0 - WPB-18877 #3421

wants to merge 17 commits into from

Conversation

netbe
Copy link
Collaborator

@netbe netbe commented Aug 1, 2025 •
edited by KaterinaWire
Loading

Issue

Bump to CC 8.0:
https://github.com/wireapp/core-crypto/releases

  • Updates new Types
  • Update tests (DataModel...)
  • Update MockCoreCryptoProtocol
  • create AppVersionMigration 4.2.1 that call coreCrypto.updateDatabaseKey
  • Check AppVersionMigration 4.2.1 is runned if app version is 4.3.0

Testing

TBD

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@netbe netbe requested a review from KaterinaWire August 1, 2025 14:08
@KaterinaWire KaterinaWire marked this pull request as ready for review August 6, 2025 07:48
jullianm
jullianm approved these changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@jullianm jullianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I added minor suggestions to use an explicit naming coreCrypto... rather than. cc.. on the variable names.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025 •
edited
Loading

Test Results

    4 files    574 suites   8m 10s ⏱️
4 374 tests 4 346 ✅ 27 💤 1 ❌
4 374 runs  4 347 ✅ 27 💤 0 ❌

For more details on these failures, see this check.

Results for commit 3c4d4b8.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnxnguyen johnxnguyen johnxnguyen approved these changes

@jullianm jullianm jullianm approved these changes

@KaterinaWire KaterinaWire Awaiting requested review from KaterinaWire

Assignees

@netbe netbe

@KaterinaWire KaterinaWire

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@netbe @johnxnguyen @jullianm @KaterinaWire