-
Notifications
You must be signed in to change notification settings - Fork 22
chore: personal-account-lifecycle test - WPB-19192 #3435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Test Results2 186 tests 2 159 ✅ 2m 28s ⏱️ Results for commit f847767. ♻️ This comment has been updated with latest results. |
@@ -86,17 +86,18 @@ class SelfUserAPIV0: SelfUserAPI, VersionedAPI { | |||
.parse(code: response.statusCode, data: data) | |||
} | |||
|
|||
func updateHandle(handle: String) async throws { | |||
func updateHandle(accessToken access_token: String, handle: String) async throws { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: could you explain this change? My guess is that you want to inject an access token, but why not mock it from the authentication manager?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnxnguyen While creating 2 users , for 2nd user updating handle uses the previous user token as active and doesn't generate new token which leads to update handle for 2nd user, it updates the 1st one and creating a mismatch with different handle for different name. By injecting the current user access_token explicitly use the valid cookie/token to update handle. Not sure how we can invalidate the active token or mock it while executing request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried removing old user cookie and store new cookie and getting stored as well but accesstoken with user1 is valid it simply doesn't go that way to create new for user2
Issue
Please describe the issue.
Optional: add details about technical approach, solutions etc.
Optional: reference dependencies to other pull requests etc.
Testing
Describe how to test.
Optional: attachments like images, videos, etc.
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: