Skip to content

feat(api): handle too many requests - WPB-21012#3724

Merged
netbe merged 8 commits intodevelopfrom
feat/handle-too-many-requests
Oct 17, 2025
Merged

feat(api): handle too many requests - WPB-21012#3724
netbe merged 8 commits intodevelopfrom
feat/handle-too-many-requests

Conversation

@netbe
Copy link
Collaborator

@netbe netbe commented Oct 13, 2025

TaskWPB-21012 [iOS] handling too many requests - login

Issue

While working on #3362, handling 429 error (tooManyRequests on login) was added. As the PR was never merged, this PR just ports this error handling.

  • add error handling: log error
  • add logout shortcut on DeveloperTools

Testing

login/ logout too many times

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@netbe netbe requested review from a team, jullianm and samwyndham and removed request for a team October 13, 2025 07:29
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025

Test Results

2 207 tests   2 180 ✅  2m 19s ⏱️
  332 suites     27 💤
    2 files        0 ❌

Results for commit 1318657.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jullianm jullianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@netbe netbe enabled auto-merge October 15, 2025 07:02
@netbe netbe added this pull request to the merge queue Oct 17, 2025
Merged via the queue into develop with commit 1a727bb Oct 17, 2025
10 checks passed
@netbe netbe deleted the feat/handle-too-many-requests branch October 17, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants