Move DB interactions for client to wire-subsystems#4984
Open
akshaymankar wants to merge 6 commits intodevelopfrom
Open
Move DB interactions for client to wire-subsystems#4984akshaymankar wants to merge 6 commits intodevelopfrom
akshaymankar wants to merge 6 commits intodevelopfrom
Conversation
zebot
added
the
ok-to-test
akshaymankar
force-pushed
the
client-store
branch
from
14a40df to
a9392d5
Compare
akshaymankar
changed the base branch from
develop
to
user-client-index-store
akshaymankar
force-pushed
the
client-store
branch
3 times, most recently
from
c7236cd to
df2205a
Compare
akshaymankar
force-pushed
the
client-store
branch
from
df2205a to
5bceb1d
Compare
battermann
approved these changes
Feb 24, 2026
Contributor
battermann
left a comment
battermann
left a comment
There was a problem hiding this comment.
Only a minor comment. Otherwise LGTM.
| allClients <- lift (wrapClient (API.lookupUsersClientIds (pure usr))) >>= getResult | ||
| clientInfos <- lift . wrapClient $ UnliftIO.Async.pooledMapConcurrentlyN 16 (\c -> getMLSClient lusr c suiteTag) (toList allClients) | ||
| allClients <- lift (liftSem (ClientStore.lookupClientIds usr)) | ||
| clientInfos <- lift $ traverse (\c -> getMLSClient lusr c suiteTag) (toList allClients) |
Contributor
There was a problem hiding this comment.
Should we keep the parallel lookup here? Even with max 8 clients, this should be a significant improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Add a new entry in an appropriate subdirectory ofNo changelog.changelog.d