Skip to content

Fix bad EGPObject invalid function #3197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Denneisk merged 1 commit into from
Dec 3, 2024
Merged

Fix bad EGPObject invalid function #3197

Denneisk merged 1 commit into from
Dec 3, 2024

Conversation

@Denneisk
Copy link
Member

@Denneisk Denneisk commented Dec 2, 2024 •
edited
Loading

Before this PR, the NULL EGPObject would be duplicated each time it was pulled from a table, since it would be deemed invalid.

Fixes this bug in particular,

T = table(noegpobject(), noegpobject())

assert(noegpobject() == noegpobject()) # passes
assert(T[1, egpobject] == T[2, egpobject]) # fails

@Denneisk Denneisk mentioned this pull request Dec 2, 2024
Merged
@Denneisk Denneisk merged commit 95698ba into wiremod:master Dec 3, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@thegrb93 thegrb93 thegrb93 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Denneisk @thegrb93