Skip to content

Conversation

@fredriknorlin
Copy link

Changes

Fixes a bug where Astro's i18n fallback system with fallbackType: 'rewrite' would not generate fallback files for pages whose filename started with a locale key.

Closes: #14359

(PS. This is my first PR in this project, so please let me know if I have missed anything)

Testing

  • Added tests covering some different locale positions in both folders and pages (folder names turned out to also be affected).
  • Although the fix turned out to be a oneliner, I kept the tests for future cover.

Docs

N/A: Bug fix

…ale keys

Fixes a bug where Astro's i18n fallback system with fallbackType: 'rewrite' would not generate fallback files for pages whose filename started with a locale key.

Fixes: withastro#14359
@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2025

🦋 Changeset detected

Latest commit: f96090a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 30, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 30, 2025

CodSpeed Performance Report

Merging #14690 will not alter performance

Comparing fredriknorlin:fix/i18n-fallbacks (f96090a) with main (f657183)1

Summary

✅ 6 untouched

Footnotes

  1. No successful run was found on main (420836c) during the generation of this report, so f657183 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i18n fallback pages are not generated at build when page filename starts with locale key

1 participant