Skip to content

fix(deps): bump to @netlify/functions v5 to shave 82 MB from @astrojs/netlify #14716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −37
Open

fix(deps): bump to @netlify/functions v5 to shave 82 MB from @astrojs/netlify #14716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
edb8975
fix(deps): bump to @netlify/functions v5 to save 82 MB
serhalp Nov 5, 2025
993921d
chore: add changeset
serhalp Nov 5, 2025
1e71e4a
chore: address changeset copy feedback
serhalp Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slimy-coins-follow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@astrojs/netlify': patch
---

Upgrades `@netlify/functions` to v5. This removes 82 MB and 310 dependencies from the dependency tree. See [the relevant release notes](https://github.com/netlify/primitives/releases/tag/functions-v5.0.0).
Copy link
Member

@sarah11918 sarah11918 Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Upgrades `@netlify/functions` to v5. This removes 82 MB and 310 dependencies from the dependency tree. See [the relevant release notes](https://github.com/netlify/primitives/releases/tag/functions-v5.0.0).
Upgrades the `@netlify/functions` dependency to v5. This removes 82 MB and 310 dependencies from the dependency tree.
There are no breaking changes to Astro's Netlify adapter in this release, even though this is a major dependency upgrade. See [the Netlify release notes](https://github.com/netlify/primitives/releases/tag/functions-v5.0.0) for more details about `@netlify/functions` v5.

Just wanted to be clear about no breaking changes for us, since this is a major dependency upgrade. (e.g. Ema's first reaction was to question this, so it should go in the notes so that people aren't wondering the same thing themselves!) So maybe something like above? (Please correct if the wording could be more accurate)

Copy link
Author

@serhalp serhalp Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 As a developer, I would be surprised if I saw release notes for my dependency that mentioned a lack of breaking changes in an upgrade of one of its dependencies.

A dependency's dependencies are an implementation detail (until they aren't 😆). So I would personally suggest just documenting what the impact of the change is for @astrojs/netlify's users—in this case, it's a smaller dependency tree and faster install size.

Of course this is just my opinion! Let me know 🙂.

2 changes: 1 addition & 1 deletion packages/integrations/netlify/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"@astrojs/internal-helpers": "workspace:*",
"@astrojs/underscore-redirects": "workspace:*",
"@netlify/blobs": "^10.3.1",
"@netlify/functions": "^4.3.0",
"@netlify/functions": "^5.0.1",
"@netlify/vite-plugin": "^2.7.8",
"@vercel/nft": "0.30.3",
"esbuild": "^0.25.0",
Expand Down
38 changes: 2 additions & 36 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading