Skip to content

Conversation

@delucis
Copy link
Member

@delucis delucis commented Nov 3, 2025

Description

  • Follow-up Tweak a11y e2e tests #3507
  • I realised we could just skip the a11y CI job early for docs changes where content changes in languages we’re not running the a11y checks for. This PR updates the workflow file to check if Japanese and English pages changed (or if any non-content files in the docs package changed) and only runs the a11y job if they have.
  • The filter for English content excludes all content files with a xx or xx-xx initial path segment. This could in theory break if we ever had an English to-do folder or something, but I think that’s not super likely and we can deal with it if it does come up.

@changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2025

⚠️ No Changeset found

Latest commit: fb005a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Nov 3, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit fb005a0
🔍 Latest deploy log https://app.netlify.com/projects/astro-starlight/deploys/6908860718ba9b0008cc7730
😎 Deploy Preview https://deploy-preview-3520--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the 🚨 action Changes to GitHub Action workflows label Nov 3, 2025
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Nov 3, 2025

size-limit report 📦

Path Size
/index.html 7.29 KB (0%)
/_astro/*.js 25.76 KB (0%)
/_astro/*.css 14.29 KB (0%)

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent idea, love it 🧠

I guess after all this, the only remaining thing will be how to speed up anything running on Windows 😅

@github-actions github-actions bot added the 📚 docs Documentation website changes label Nov 3, 2025
@delucis delucis merged commit 60592b9 into main Nov 3, 2025
17 checks passed
@delucis delucis deleted the chris/ci-skip-a11y branch November 3, 2025 10:44
delucis added a commit that referenced this pull request Nov 3, 2025
delucis added a commit that referenced this pull request Nov 3, 2025
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Nov 5, 2025
* main: (47 commits)
  feat: add some of trueberryless' new Starlight blogs to community content (withastro#3525)
  i18n(fr): update `resources/themes` (withastro#3526)
  Fix file filters added in withastro#3520 (withastro#3522)
  i18n(fr): update `guides/site-search.mdx` (withastro#3524)
  i18n(fr): update `resources/plugins.mdx` (withastro#3523)
  docs: add starlight-themes link (withastro#3510)
  i18n(de): update translation resources/plugins.mdx (withastro#3519)
  i18n(de): update translation guides/site-search.mdx (withastro#3518)
  Skip a11y CI checks for docs changes that aren’t tested anyway (withastro#3520)
  Speed up Linux e2e tests (withastro#3517)
  i18n(ru): update translations (withastro#3512)
  Tweak a11y e2e tests (withastro#3507)
  [ci] format
  docs(plugin): starlight-docsearch-typesense (withastro#3504)
  Add starlight-page-actions (withastro#3515)
  ci: update file icons (withastro#3511)
  [i18nIgnore] Match title case convention for components/using-components (withastro#3508)
  Disable Prettier on GitHub Actions workflow files (withastro#3509)
  [ci] release (withastro#3490)
  Update release workflow for OIDC (withastro#3500)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚨 action Changes to GitHub Action workflows 📚 docs Documentation website changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants