Skip to content

Conversation

@HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Nov 5, 2025

Description

This PR refactors how Pagefind is run after the build process. Instead of using the CLI via npx, it now uses the Pagefind API directly.

Feature-wise, there should be no changes but one aspect which will differ is logging.

Before After
SCR-20251105-oazh SCR-20251105-ocrn

We are now directly using a fork of the Starlight ingration logger. I didn't spend too much time on tweaking the logging output so far, but one huge difference is that we don't have access to the same informations when using the API vs CLI which access them using some internal Rust code and that data is not exposed via the API.

Personally, I never found the logging output of the CLI very useful, so I think this is an overall improvement but definitely something worth mentioning and discussing if needed.

@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2025

⚠️ No Changeset found

Latest commit: 746968f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Nov 5, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 746968f
🔍 Latest deploy log https://app.netlify.com/projects/astro-starlight/deploys/690b6b92069c55000862a00a
😎 Deploy Preview https://deploy-preview-3534--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌟 core Changes to Starlight’s main package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pagefind forces the use of npx to run which may not be available

1 participant