Skip to content

Conversation

@HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Nov 6, 2025

Description

Continuing on the effort to speed up CI, I noticed that on Windows, the E2E tests took 3 minutes to install some dependendcies before even starting to download Chrome.

After checking the Playwright core codebase, it turns out that this is due to the installation of the Server Media Foundation windows feature on Windows Server.

Altho, something I noticed is that this is only required for Chromium-based browsers.

Therefore, this PR changes the Windows E2E tests on CI to use Firefox instead of Chrome, which skips this step and immediately starts downloading Firefox before running the tests.

Before After
SCR-20251106-pldu SCR-20251106-pmaz

This also has the added benefit of running our E2E tests on a different browser.

@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2025

⚠️ No Changeset found

Latest commit: 4cf37f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Nov 6, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 4cf37f6
🔍 Latest deploy log https://app.netlify.com/projects/astro-starlight/deploys/690cce439626700007d61bad
😎 Deploy Preview https://deploy-preview-3538--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added 🚨 action Changes to GitHub Action workflows 🌟 core Changes to Starlight’s main package labels Nov 6, 2025
@HiDeoo HiDeoo changed the title ci: windows e2e tests tweaks ci: use Firefox for Windows E2E tests Nov 6, 2025
@HiDeoo HiDeoo marked this pull request as ready for review November 6, 2025 16:44
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible investigation and discovery 🔥

I think we’ll need a blog post soon about all these tricks!

Thanks @HiDeoo 🙌

@HiDeoo HiDeoo merged commit 5a89a16 into withastro:main Nov 7, 2025
16 checks passed
@HiDeoo HiDeoo deleted the hd/ci-playwright-windows-firefox branch November 7, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚨 action Changes to GitHub Action workflows 🌟 core Changes to Starlight’s main package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants