Upgradeable staker (DO NOT MERGE) #154
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkeating
commented
Aug 11, 2025
src/extensions/StakerCapDeposits.sol
Outdated
| uint256 _totalStakeCap; | ||
| } | ||
|
|
||
| // keccak256(abi.encode(uint256(keccak256("storage.StakerCapDeposits")) - 1)) &~bytes32(uint256(0xff)) |
There was a problem hiding this comment.
Add vendor subdomain
alexkeating
commented
Aug 11, 2025
alexkeating
commented
Aug 11, 2025
alexkeating
commented
Aug 11, 2025
|
|
||
| /// @notice Delegable governance token which users stake to earn rewards. | ||
| IERC20 public immutable STAKE_TOKEN; | ||
| struct StakerStorage { |
There was a problem hiding this comment.
Does cause multiple slot reads? Make sure gas estimations are still reasonable
There was a problem hiding this comment.
Targeting zksync, not a huge change so we will not optimize
alexkeating
commented
Aug 14, 2025
| // Public getter functions for storage variables | ||
|
|
||
| /// @notice ERC20 token in which rewards are denominated and distributed. | ||
| function REWARD_TOKEN() public view virtual returns (IERC20) { |
There was a problem hiding this comment.
Should these still be capitalized
There was a problem hiding this comment.
Also are there any of these getters we should remove
alexkeating
commented
Aug 14, 2025
|
|
||
| /// @notice Initializes the the contract. | ||
| /// @param _initialTotalStakeCap The initial maximum total stake allowed. | ||
| function __StakerCapDepositsUpgradeable_init_unchained(uint256 _initialTotalStakeCap) |
There was a problem hiding this comment.
Kept these to match convention, but they seem to only be used as a passthrough
alexkeating
commented
Aug 20, 2025
| } | ||
|
|
||
| /// @notice Current configuration parameters for the fee assessed on claiming. | ||
| function claimFeeParameters() public view virtual returns (ClaimFeeParameters memory) { |
There was a problem hiding this comment.
Should this return a tuple to maintain compatibility with the regular Staker?
alexkeating
commented
Sep 5, 2025
| __StakerDelegateSurrogateVotesUpgradeable_init_unchained(_votingToken); | ||
| } | ||
|
|
||
| /// @notice Initializes the the contract. |
There was a problem hiding this comment.
Suggested change
| /// @notice Initializes the the contract. | |
| /// @notice Initializes the `StakerDelegateSurrogateVotesUpgradeable` contract. |
| return _domainSeparatorV4(); | ||
| } | ||
|
|
||
| /// @notice Initializes the the contract. |
There was a problem hiding this comment.
Suggested change
| /// @notice Initializes the the contract. | |
| /// @notice Initializes the `StakerOnBehalfUpgradeable` contract. |
|
Coverage after merging upgradeable-staker into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description