Add unclaimed reward invariant test #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyghayrat
force-pushed
the
test/add-sum-of-rewards-invariant
branch
from
54da214 to
738740b
Compare
apbendi
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Looks great @garyghayrat. One nit on naming, but we can merge after fixing!
test/Staker.invariants.t.sol
Outdated
| @@ -77,6 +77,13 @@ contract StakerInvariants is Test { | |||
| ); | |||
| } | |||
|
|
|||
| function invariant_Sum_of_unclaimed_reward_should_be_less_than_or_equal_to_total_rewards() public { | |||
There was a problem hiding this comment.
We should consider extending the last part of the name for clarity: _total_rewards_balance(). Saying simply "total rewards" makes it sound like it could mean all rewards ever.
There was a problem hiding this comment.
renamed in 8d2844e
|
Coverage after merging test/add-sum-of-rewards-invariant into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #15