-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to ignore cache #23
Conversation
LironMShemen
commented
Oct 21, 2024
- Introduced a new environment variable to bypass cache.
- Updated README to include usage instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
round 2
- Introduced a new environment variable to bypass cache. - Updated README to include usage instructions.
04d3442
to
af6c96c
Compare
I changed my code according to the comments. Mistakenly, I did the commit with amend. |
Actually, squashing (or in this case - amending) commit changes after a code review is actually a great practice as it keeps the history clean and focused on the final, relevant changes. For larger reviews, I do prefer separate commits to show the specific fixes from the code review, and then once everything is approved, we can squash them into more meaningful, contained commits. However, since that's a small change, I'm perfectly fine with the amend approach here, it keeps things clean and simple |
Co-authored-by: Asaf Korem <[email protected]>