Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to ignore cache #23

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

LironMShemen
Copy link
Contributor

  • Introduced a new environment variable to bypass cache.
  • Updated README to include usage instructions.

@asafkorem asafkorem self-assigned this Oct 21, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@asafkorem asafkorem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

round 2

README.md Outdated Show resolved Hide resolved
src/actions/StepPerformer.ts Outdated Show resolved Hide resolved
- Introduced a new environment variable to bypass cache.
- Updated README to include usage instructions.
@LironMShemen
Copy link
Contributor Author

I changed my code according to the comments. Mistakenly, I did the commit with amend.

@asafkorem
Copy link
Collaborator

Actually, squashing (or in this case - amending) commit changes after a code review is actually a great practice as it keeps the history clean and focused on the final, relevant changes.

For larger reviews, I do prefer separate commits to show the specific fixes from the code review, and then once everything is approved, we can squash them into more meaningful, contained commits.

However, since that's a small change, I'm perfectly fine with the amend approach here, it keeps things clean and simple

src/actions/StepPerformer.test.ts Outdated Show resolved Hide resolved
src/actions/StepPerformer.ts Outdated Show resolved Hide resolved
@asafkorem asafkorem merged commit a8aee52 into master Oct 22, 2024
1 check passed
@asafkorem asafkorem deleted the add-override-cache-to-env branch October 22, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants