-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defer notifications while performing action #247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirlynwix
approved these changes
Jan 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
See small suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
deferSubscriberNotifications
Function that defers subscribers (and observables) notification until the end of some action. This is necessary when running a flow that creates intermediate states we don't want to react to.To handle the conflict between
deferSubscriberNotifications
andflush
, add optional config to the flush function:excecutionType: default
- meaning flush would happen right after we stop deferring notifications. Flush when not deferring notifications stays the same.excecutionType: scheduled
- meaning flush would notify all without canceling render and requesting animation frame, regardless if notifications are currently being deferred.excecutionType: immediate
- meaning flush would happen immediately regardless if notifications are currently being deferred.In general, the
deferSubscriberNotifications
solution is:deferSubscriberNotifications
receives some action we would like to perform while deferring notifications.deferSubscriberNotifications
)deferNotifications
flag to true before running the actionnotifyAll
whiledeferNotifications
is set to true, return without notifyingdeferNotifications
back to false, and flush\notify if someone tried to flush (not immediate) or notify while deferring notifications.