fix: missing closing tabs with wallet loading #1787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tACK a242834, it fixes the issue of panic if we remove a wallet during IBD |
If the focused tab index is before the removed tab index, then it must not change, if it is equal or after, because all the elements are moved to the left, the focused tab index must be decremented with 0 as minimum.
|
tACK 88966c2, it fixes the second issue |
edouardparis
added a commit
that referenced
this pull request
Jul 24, 2025
1249f4f fix: missing closing tabs with wallet loading (edouardparis) c9a57ae fix: move focused_tab if >= removed index (edouardparis) Pull request description: Backport #1787 ACKs for top commit: edouardparis: Self-ACK 1249f4f Tree-SHA512: 3a7c7ae150ca2dbea9a956b0f8fcb0936c96d4c7458efa2804de6fcbb69beb010ee79d8453e371b83e141d7e93d1de90dd9be5d502e990ce9e15ee713fc9abfb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.