Skip to content

Conversation

@Skitionek
Copy link

@Skitionek Skitionek commented Feb 20, 2023

Summary

  • Exceptions are printed only on cli (otherwise simply raised)
  • Allows for custom progress callbacks (which defaults to old behaviour)
  • stderr stands for "standard error" - progress messages should be printed to stdin

@wkentaro
Copy link
Owner

The change to Exception looks good, but I'm not sure about others. If you split PRs, we can merge some of them earlier.

@wkentaro
Copy link
Owner

Regarding stderr vs stdout, this is the reason why we keep stderr for the log messages.

image

@Skitionek
Copy link
Author

Regarding stderr vs stdout, this is the reason why we keep stderr for the log messages.

image

Interesting, yet putting flag --quiet should silence all progress prints from code.... Therefore it still can be used the way you mentioned.

@Skitionek
Copy link
Author

The change to Exception looks good, but I'm not sure about others. If you split PRs, we can merge some of them earlier.

Moved Exceptions to separate PR: #246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants