Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into what needs to happen to support the pkg: import syntax #108

Closed
4 tasks done
wkillerud opened this issue Feb 16, 2024 · 2 comments
Closed
4 tasks done

Look into what needs to happen to support the pkg: import syntax #108

wkillerud opened this issue Feb 16, 2024 · 2 comments
Assignees

Comments

@wkillerud
Copy link
Owner

wkillerud commented Feb 16, 2024

See Sass announcement of the feature

No longer will you have to manually add node_modules to your loadPaths option and worry about whether nested packages will work at all. No longer will you need to add ~s to your URLs and give up all portability. Now you can just pass importers: [new NodePackageImporter()] and write @use 'pkg:library' and it’ll work just how you want out of the box.

TODO

@wkillerud wkillerud self-assigned this Feb 16, 2024
@wkillerud
Copy link
Owner Author

wkillerud commented Feb 16, 2024

See how the new syntax affects the parser and how it handles links

Poorly. The parser doesn't register them as links. It also breaks Cmd+click to navigate, which is provided by vscode-css-languageservices (an issue is open in microsoft/vscode-css-languageservice#383). Might be best to land support for this upstream, rather than patching it in here (microsoft/vscode-css-languageservice#384)

See how the the import completion is affected by the new import syntax

Also poorly, but this one is on me.

@wkillerud
Copy link
Owner Author

See if it makes sense to use the official importer via the JS API

There's a canonicalize method that looked promising, but it's not part of the public API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant