feat: support pkg: imports
#110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findDocumentLinks2 returns proper URLs without pkg:, but I made some assumptions when comparing the import string to the file URL.
|
Continued in #137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, pending some changes landing in
vscode-css-languageservice. With these changes and microsoft/vscode-css-languageservice#384 the parser works as expected, and we get hover info, code navigation, code completion, color annotations – the works. Still todo:npm linkagainsvscode-css-languageservicepkg:syntax to the import completion #109ISSUES CLOSED: #108, #109