Update openapi.yaml to openai/openai-openapi commit 33d5c27 (latest as of Jun 9th)
#64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks! There's normally a few manual changes needed documented here: https://github.com/wkok/openai-clojure/blob/main/resources/openapi-README.md I'll merge this PR and make those changes after. Regarding the tests, |
Contributor
Author
|
oh I sure didn't realize that regarding bb test.
I read the README document, but I wasn't sure if it's still relevant, you
know especially with openapi specs got updated so frequently.
Werner Kok ***@***.***> 于2024年6月10日周一 15:06写道：
… Thanks!
There's normally a few manual changes needed documented here:
https://github.com/wkok/openai-clojure/blob/main/resources/openapi-README.md
I'll merge this PR and make those changes after.
Regarding the tests, bb test is deceiving in that it does not actually
run the tests due to this reflection PR
<https://github.com/wkok/openai-clojure/pull/48/files> that was merged a
while back. I think I'm going to revert the reflection warning change as
running tests are more important.
—
Reply to this email directly, view it on GitHub
<#64 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIIWBJK5XF35JNRUML42I7LZGX2K3AVCNFSM6AAAAABJBMJTLKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJZGEYDAMBVHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Copy and paste
openai-openapiyaml file and replace existing ones. The major motivation is OpenAI added a new parameter,tool_choiceinto theRunObjecttype(see this line vs current repo run object, because my project uses theAssistantsAPI a lot I noticed that missingtool_choicecauses my project to work as expected.Test
I ran the
bb testin my local repo. Returns:misc
I noticed that OpenAI has a lot of updates while the version handily stays at
2.0.0: https://github.com/openai/openai-openapi/blame/master/openapi.yaml#L5, any thoughts on usinggit submoduleto maintain API specs compatibility ? (Assuming in this repo there's no manual update).